* [uml-devel] [PATCH] UML - Change timer initialization @ 2006-05-01 20:46 Jeff Dike 2006-05-01 21:58 ` [uml-devel] " Andrew Morton 0 siblings, 1 reply; 3+ messages in thread From: Jeff Dike @ 2006-05-01 20:46 UTC (permalink / raw) To: akpm; +Cc: linux-kernel, user-mode-linux-devel This is definite 2.6.17 material... As of rc3-mm1, inet_init, which schedules, is called before the UML timer_init, which sets up the timer. The result is the interval timers being manipulated before the appropriate signal handlers are established, causing unhandled timers. This is fixed by making timer_init be called earlier. Signed-off-by: Jeff Dike <jdike@addtoit.com> Index: linux-2.6.17-mm/arch/um/kernel/time_kern.c =================================================================== --- linux-2.6.17-mm.orig/arch/um/kernel/time_kern.c 2006-03-23 16:40:20.000000000 -0500 +++ linux-2.6.17-mm/arch/um/kernel/time_kern.c 2006-05-01 17:34:41.000000000 -0400 @@ -209,4 +209,4 @@ int __init timer_init(void) return(0); } -__initcall(timer_init); +arch_initcall(timer_init); ------------------------------------------------------- Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 _______________________________________________ User-mode-linux-devel mailing list User-mode-linux-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel ^ permalink raw reply [flat|nested] 3+ messages in thread
* [uml-devel] Re: [PATCH] UML - Change timer initialization 2006-05-01 20:46 [uml-devel] [PATCH] UML - Change timer initialization Jeff Dike @ 2006-05-01 21:58 ` Andrew Morton 2006-05-01 22:31 ` Jeff Dike 0 siblings, 1 reply; 3+ messages in thread From: Andrew Morton @ 2006-05-01 21:58 UTC (permalink / raw) To: Jeff Dike; +Cc: linux-kernel, user-mode-linux-devel Jeff Dike <jdike@addtoit.com> wrote: > > This is definite 2.6.17 material... > > As of rc3-mm1, inet_init, which schedules, is called before the UML timer_init, > which sets up the timer. The result is the interval timers being manipulated > before the appropriate signal handlers are established, causing unhandled > timers. > Which means nobody's tested uml against the last couple of -mm's. Bad. ------------------------------------------------------- Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 _______________________________________________ User-mode-linux-devel mailing list User-mode-linux-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel ^ permalink raw reply [flat|nested] 3+ messages in thread
* [uml-devel] Re: [PATCH] UML - Change timer initialization 2006-05-01 21:58 ` [uml-devel] " Andrew Morton @ 2006-05-01 22:31 ` Jeff Dike 0 siblings, 0 replies; 3+ messages in thread From: Jeff Dike @ 2006-05-01 22:31 UTC (permalink / raw) To: Andrew Morton; +Cc: linux-kernel, user-mode-linux-devel On Mon, May 01, 2006 at 02:58:37PM -0700, Andrew Morton wrote: > Which means nobody's tested uml against the last couple of -mm's. Bad. Yeah. I didn't check rc2-mm1 because it came out after rc3, and I missed rc1-mm3. But rc1-mm2 was OK. Jeff ------------------------------------------------------- Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 _______________________________________________ User-mode-linux-devel mailing list User-mode-linux-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2006-05-01 23:31 UTC | newest] Thread overview: 3+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2006-05-01 20:46 [uml-devel] [PATCH] UML - Change timer initialization Jeff Dike 2006-05-01 21:58 ` [uml-devel] " Andrew Morton 2006-05-01 22:31 ` Jeff Dike
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox