Re: [uml-devel] [PATCH] uml: fix signal code x86-64 [for 2.6.15]

[Blaisorblade <blaisorblade@yahoo.it>]

On Sunday 04 June 2006 21:06, Andi Kleen wrote:
> > It isn't yet perfect, because we don't yet save floating point context.
> > But that will come later. Additionally, there's a potential problem since
> > RED zones will alternate stacks are used, unlike x86_64, so more stack
> > space (128 bytes more) is used. But this shouldn't be a problem.
> > Instead, having no red zone (like x86_64)
>
> x86-64 has a red zone.

On the alternate stack too? The comment in the below code confused me... even 
if when nesting signal frames sas_ss_flags(rsp) should be 0 and so the 
redzone will be used.
The below "RED-PEN" comment is probably wrong then... or not?

arch/x86_64/kernel/signal.c:
        /* RED-PEN: redzone on that stack? */
        if (ka->sa.sa_flags & SA_ONSTACK) {
                if (sas_ss_flags(rsp) == 0)
                        rsp = current->sas_ss_sp + current->sas_ss_size;
        }
> Is your description confused or your code? 
Sorry for the ambiguity and typos in the desc.
-- 
Inform me of my mistakes, so I can keep imitating Homer Simpson's "Doh!".
Paolo Giarrusso, aka Blaisorblade (Skype ID "PaoloGiarrusso", ICQ 215621894)
http://www.user-mode-linux.org/~blaisorblade
Chiacchiera con i tuoi amici in tempo reale! 
 http://it.yahoo.com/mail_it/foot/*http://it.messenger.yahoo.com 



_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel