linux-um archives
 help / color / mirror / Atom feed
From: Andi Kleen <ak@suse.de>
To: Blaisorblade <blaisorblade@yahoo.it>
Cc: jdike@addtoit.com, user-mode-linux-devel@lists.sourceforge.net
Subject: Re: [uml-devel] [PATCH] uml: fix signal code x86-64 [for 2.6.15]
Date: Tue, 6 Jun 2006 01:39:18 +0200	[thread overview]
Message-ID: <200606060139.18327.ak@suse.de> (raw)
In-Reply-To: <200606051306.53234.blaisorblade@yahoo.it>

On Monday 05 June 2006 13:06, Blaisorblade wrote:
> On Sunday 04 June 2006 21:06, Andi Kleen wrote:
> > > It isn't yet perfect, because we don't yet save floating point context.
> > > But that will come later. Additionally, there's a potential problem since
> > > RED zones will alternate stacks are used, unlike x86_64, so more stack
> > > space (128 bytes more) is used. But this shouldn't be a problem.
> > > Instead, having no red zone (like x86_64)
> >
> > x86-64 has a red zone.
> 
> On the alternate stack too? 

No, there not.

> The comment in the below code confused me... even  
> if when nesting signal frames sas_ss_flags(rsp) should be 0 and so the 
> redzone will be used.
> The below "RED-PEN" comment is probably wrong then... or not?
> 
> arch/x86_64/kernel/signal.c:
>         /* RED-PEN: redzone on that stack? */

It's bogus because the alternative stack cannot be nested. I will remove it.



_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel

  reply	other threads:[~2006-06-05 23:41 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-06-04 18:52 [uml-devel] [PATCH] uml: fix signal code x86-64 [for 2.6.15] Paolo 'Blaisorblade' Giarrusso
2006-06-04 19:06 ` Andi Kleen
2006-06-05 11:06   ` Blaisorblade
2006-06-05 23:39     ` Andi Kleen [this message]
2006-07-09 16:30       ` Blaisorblade

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200606060139.18327.ak@suse.de \
    --to=ak@suse.de \
    --cc=blaisorblade@yahoo.it \
    --cc=jdike@addtoit.com \
    --cc=user-mode-linux-devel@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox