Re: [uml-devel] [PATCH] Fix UML build on i386 Ubuntu Dapper

[Blaisorblade <blaisorblade@yahoo.it>]

On Wednesday 28 June 2006 02:47, Nishanth Aravamudan wrote:
> On 27.06.2006 [11:31:28 -0700], Nishanth Aravamudan wrote:
> > On 27.06.2006 [16:56:13 +0200], Blaisorblade wrote:
> > > On Tuesday 27 June 2006 00:02, Nishanth Aravamudan wrote:
> > > > Hi Jeff,
> > > >
> > > > I run an x86_64 kernel with i386 userspace (Ubuntu Dapper) and
> > > > decided to try out UML today. I found that UML wasn't quite aware of
> > > > biarch compilers (which Ubuntu i386 ships). A fix similar to what was
> > > > done for x86_64 should probably be committed (see
> > > > http://marc.theaimsgroup.com/?l=linux-kernel&m=113425940204010&w=2).
> > >
> > > Ok, it seemed strange but I understand the stuff... that's very
> > > interesting as this is the setup I'd wished to have since ages. I'll
> > > switch to it ASAP...
> >
> > Indeed :)
> >
> > > > Without the FLAGS changes, the build will fail at a number of places
> > > > and without the LINK change, the final link will fail.
> > > >
> > > > Signed-off-by: Nishanth Aravamudan <nacc@us.ibm.com>
> > >
> > > The first hunk (#undef i386) should be unnecessary given you specify
> > > -m64 (add it to CPPFLAGS too). Also it can/could be problematic for
>
> Hrm, I somehow overlooked the CPPFLAGS bit. Is it necessary? That wasn't
> changed for x86_64 and having not changed it for UML, it doesn't appear
> to have prevented the build from working on both x86_64 and i386
> SUBARCHs here.

It shouldn't go in the general CPPFLAGS indeed.
I think that -m64 in the preprocessor command used to build vmlinux.lds.S 
would be cleaner than #undef i386... test it by preprocessing by hand and 
report, I'll code the CPPFLAGS_vmlinux.lds.S = -m64 assignment (if it is 
exactly this way) if it works.

Anyway, this is minor refinement, the patch is otherwise ok.
-- 
Inform me of my mistakes, so I can keep imitating Homer Simpson's "Doh!".
Paolo Giarrusso, aka Blaisorblade (Skype ID "PaoloGiarrusso", ICQ 215621894)
http://www.user-mode-linux.org/~blaisorblade
Chiacchiera con i tuoi amici in tempo reale! 
 http://it.yahoo.com/mail_it/foot/*http://it.messenger.yahoo.com 


Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel