[uml-devel] comments in ubd_kern.c

[uml-devel] comments in ubd_kern.c

[Chris Lightfoot]

Presently the code in ubd_kern.c carries the following
comments:

  - for ubd_handler,

    /* Called without ubd_io_lock held */

  - for do_ubd_request,

    /* Called with ubd_io_lock held */

ubd_handler locks ubd_io_lock before calling end_request,
but it then calls do_ubd_request, after releasing the
lock. But at the end of ubd_handler, it calls
do_ubd_request, and doesn't acquire the spinlock before
doing so. Am I missing something or is this an error?

-- 
Something must be done. This is something, so we must do it.
(characterising government-by-reaction)


-------------------------------------------------------
This SF.Net email is sponsored by:
Power Architecture Resource Center: Free content, downloads, discussions,
and more. http://solutions.newsforge.com/ibmarch.tmpl
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel

Re: [uml-devel] comments in ubd_kern.c

[Blaisorblade]

On Tuesday 04 October 2005 16:06, Chris Lightfoot wrote:
> Presently the code in ubd_kern.c carries the following
> comments:
>
>   - for ubd_handler,
>
>     /* Called without ubd_io_lock held */
>
>   - for do_ubd_request,
>
>     /* Called with ubd_io_lock held */
>
> ubd_handler locks ubd_io_lock before calling end_request,
> but it then calls do_ubd_request, after releasing the
> lock. But at the end of ubd_handler, it calls
> do_ubd_request, and doesn't acquire the spinlock before
> doing so. Am I missing something or is this an error?
Just to let you now - 1 year + since this mail, this error has been addressed, 
and when I'll have time I'll redo your patch for write barriers against new 
barrier infrastructure.

If you still want to do it you're welcome obviously, even if you obviously 
turned away to other stuff.
-- 
Inform me of my mistakes, so I can add them to my list!
Paolo Giarrusso, aka Blaisorblade
http://www.user-mode-linux.org/~blaisorblade
Chiacchiera con i tuoi amici in tempo reale! 
 http://it.yahoo.com/mail_it/foot/*http://it.messenger.yahoo.com 


-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel