[uml-devel] [PATCH 1/6] i386 - fix cmpxchg warning

[uml-devel] [PATCH 1/6] i386 - fix cmpxchg warning

[Jeff Dike]

I started getting warnings from atomic.h about cmpxchg not having a
prototype.  It's declared in system.h, so including that fixes the UML
build warnings and has no noticable ill effects on the i386 build.

Signed-off-by: Jeff Dike <jdike@linux.intel.com>
--
 include/asm-i386/atomic.h |    1 +
 1 file changed, 1 insertion(+)

Signed-off-by: Jeff Dike <jdike@linux.intel.com>
--

Index: linux-2.6.21-mm/include/asm-i386/atomic.h
===================================================================
--- linux-2.6.21-mm.orig/include/asm-i386/atomic.h	2007-03-27 12:25:16.000000000 -0400
+++ linux-2.6.21-mm/include/asm-i386/atomic.h	2007-03-27 12:26:38.000000000 -0400
@@ -3,6 +3,7 @@
 
 #include <linux/compiler.h>
 #include <asm/processor.h>
+#include <asm/system.h>
 
 /*
  * Atomic operations that C can't guarantee us.  Useful for

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel

Re: [uml-devel] [PATCH 1/6] i386 - fix cmpxchg warning

[Andi Kleen]

>  #include <linux/compiler.h>
>  #include <asm/processor.h>
> +#include <asm/system.h>
Sorry no. system.h is the header from hell and putting it into a "basic" header
like atomic_t will likely cause all kinds of problems.

If it's a real issue move cmpxchhg into a different header and include that
from system.h and atomic.h. system.h has too much stuff anyways so it could
use any cleanup.

-Andi

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel

Re: [uml-devel] [PATCH 1/6] i386 - fix cmpxchg warning

[Jeff Dike]

On Wed, Mar 28, 2007 at 09:05:03PM +0200, Andi Kleen wrote:
> 
> >  #include <linux/compiler.h>
> >  #include <asm/processor.h>
> > +#include <asm/system.h>
> Sorry no. system.h is the header from hell and putting it into a
> "basic" header like atomic_t will likely cause all kinds of
> problems.

OK, I'll figure out someplace else for it.

				Jeff

-- 
Work email - jdike at linux dot intel dot com

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel