* [uml-devel] [PATCH 03/30] um: Don't unnecessarily cast allocation return value in ubd_kern.c [not found] <1554af80879a7ef2f78a4d654f23c248203500d9.1187912217.git.jesper.juhl@gmail.com> @ 2007-08-23 23:43 ` Jesper Juhl 2007-08-24 0:22 ` Jeff Dike 0 siblings, 1 reply; 2+ messages in thread From: Jesper Juhl @ 2007-08-23 23:43 UTC (permalink / raw) To: Linux Kernel Mailing List; +Cc: Jeff Dike, Jesper Juhl, user-mode-linux-devel vmalloc() returns a void pointer, so casting to (void *) is pretty pointless. Signed-off-by: Jesper Juhl <jesper.juhl@gmail.com> --- arch/um/drivers/ubd_kern.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/arch/um/drivers/ubd_kern.c b/arch/um/drivers/ubd_kern.c index 0eabe73..25b248a 100644 --- a/arch/um/drivers/ubd_kern.c +++ b/arch/um/drivers/ubd_kern.c @@ -615,7 +615,7 @@ static int ubd_open_dev(struct ubd *ubd_dev) blk_queue_max_sectors(ubd_dev->queue, 8 * sizeof(long)); err = -ENOMEM; - ubd_dev->cow.bitmap = (void *) vmalloc(ubd_dev->cow.bitmap_len); + ubd_dev->cow.bitmap = vmalloc(ubd_dev->cow.bitmap_len); if(ubd_dev->cow.bitmap == NULL){ printk(KERN_ERR "Failed to vmalloc COW bitmap\n"); goto error; -- 1.5.2.2 ------------------------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/ _______________________________________________ User-mode-linux-devel mailing list User-mode-linux-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel ^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [uml-devel] [PATCH 03/30] um: Don't unnecessarily cast allocation return value in ubd_kern.c 2007-08-23 23:43 ` [uml-devel] [PATCH 03/30] um: Don't unnecessarily cast allocation return value in ubd_kern.c Jesper Juhl @ 2007-08-24 0:22 ` Jeff Dike 0 siblings, 0 replies; 2+ messages in thread From: Jeff Dike @ 2007-08-24 0:22 UTC (permalink / raw) To: Jesper Juhl; +Cc: Linux Kernel Mailing List, user-mode-linux-devel On Fri, Aug 24, 2007 at 01:43:49AM +0200, Jesper Juhl wrote: > vmalloc() returns a void pointer, so casting to (void *) is pretty pointless. Righto, I'll take care of this. Jeff -- Work email - jdike at linux dot intel dot com ------------------------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/ _______________________________________________ User-mode-linux-devel mailing list User-mode-linux-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-08-24 0:22 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1554af80879a7ef2f78a4d654f23c248203500d9.1187912217.git.jesper.juhl@gmail.com>
2007-08-23 23:43 ` [uml-devel] [PATCH 03/30] um: Don't unnecessarily cast allocation return value in ubd_kern.c Jesper Juhl
2007-08-24 0:22 ` Jeff Dike
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox