linux-um archives
 help / color / mirror / Atom feed
* [PATCH] um, exec: remove redundant set_fs(USER_DS)
       [not found]     ` <BANLkTinv1teZEHMK0qymaVdcxPOErpqSyg@mail.gmail.com>
@ 2011-06-10 13:10       ` Mathias Krause
  2011-06-10 20:00         ` [uml-devel] " Richard Weinberger
  0 siblings, 1 reply; 2+ messages in thread
From: Mathias Krause @ 2011-06-10 13:10 UTC (permalink / raw)
  To: Jeff Dike
  Cc: Andrew Morton, Linus Torvalds, user-mode-linux-devel,
	linux-kernel, Mathias Krause, Richard Weinberger

The address limit is already set in flush_old_exec() so this
set_fs(USER_DS) is redundant.

Signed-off-by: Mathias Krause <minipli@googlemail.com>
Cc: Richard Weinberger <richard@nod.at>
---
 arch/um/kernel/exec.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/arch/um/kernel/exec.c b/arch/um/kernel/exec.c
index 09bd7b5..939a4a6 100644
--- a/arch/um/kernel/exec.c
+++ b/arch/um/kernel/exec.c
@@ -38,7 +38,6 @@ void flush_thread(void)
 
 void start_thread(struct pt_regs *regs, unsigned long eip, unsigned long esp)
 {
-	set_fs(USER_DS);
 	PT_REGS_IP(regs) = eip;
 	PT_REGS_SP(regs) = esp;
 }
-- 
1.5.6.5


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [uml-devel] [PATCH] um, exec: remove redundant set_fs(USER_DS)
  2011-06-10 13:10       ` [PATCH] um, exec: remove redundant set_fs(USER_DS) Mathias Krause
@ 2011-06-10 20:00         ` Richard Weinberger
  0 siblings, 0 replies; 2+ messages in thread
From: Richard Weinberger @ 2011-06-10 20:00 UTC (permalink / raw)
  To: Mathias Krause
  Cc: Jeff Dike, Linus Torvalds, Andrew Morton, user-mode-linux-devel,
	linux-kernel

Am Freitag 10 Juni 2011, 15:10:57 schrieb Mathias Krause:
> The address limit is already set in flush_old_exec() so this
> set_fs(USER_DS) is redundant.
> 
> Signed-off-by: Mathias Krause <minipli@googlemail.com>
> Cc: Richard Weinberger <richard@nod.at>

Applied.

Thanks,
//richard

------------------------------------------------------------------------------
EditLive Enterprise is the world's most technically advanced content
authoring tool. Experience the power of Track Changes, Inline Image
Editing and ensure content is compliant with Accessibility Checking.
http://p.sf.net/sfu/ephox-dev2dev
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2011-06-10 20:01 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <BANLkTiknCeAxe30MJdVTxDom+ko8+EDQ4A@mail.gmail.com>
     [not found] ` <1307642718-22257-1-git-send-email-minipli@googlemail.com>
     [not found]   ` <20110609155630.0f734351.akpm@linux-foundation.org>
     [not found]     ` <BANLkTinv1teZEHMK0qymaVdcxPOErpqSyg@mail.gmail.com>
2011-06-10 13:10       ` [PATCH] um, exec: remove redundant set_fs(USER_DS) Mathias Krause
2011-06-10 20:00         ` [uml-devel] " Richard Weinberger

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox