[uml-devel] [PATCH 1/2] um: disable funit-at-a-time for gcc < 4.3

[uml-devel] [PATCH 1/2] um: disable funit-at-a-time for gcc < 4.3

[Florian Fainelli]

From: Nicolas Thill <nico@openwrt.org>

Building UML with gcc < 4.3 with -funit-at-a-time for i386 causes startup
crashes, disabling funit-at-a-time works around it.

Signed-off-by: Nicolas Thill <nico@openwrt.org>
---
diff --git a/arch/um/Makefile-i386 b/arch/um/Makefile-i386
index 302cbe5..8251030 100644
--- a/arch/um/Makefile-i386
+++ b/arch/um/Makefile-i386
@@ -35,7 +35,7 @@ cflags-y += -ffreestanding
 # Disable unit-at-a-time mode on pre-gcc-4.0 compilers, it makes gcc use
 # a lot more stack due to the lack of sharing of stacklots.  Also, gcc
 # 4.3.0 needs -funit-at-a-time for extern inline functions.
-KBUILD_CFLAGS += $(shell if [ $(call cc-version) -lt 0400 ] ; then \
+KBUILD_CFLAGS += $(shell if [ $(call cc-version) -lt 0403 ] ; then \
 			echo $(call cc-option,-fno-unit-at-a-time); \
 			else echo $(call cc-option,-funit-at-a-time); fi ;)
 
-- 
1.7.4.1


------------------------------------------------------------------------------
EditLive Enterprise is the world's most technically advanced content
authoring tool. Experience the power of Track Changes, Inline Image
Editing and ensure content is compliant with Accessibility Checking.
http://p.sf.net/sfu/ephox-dev2dev
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel

Re: [uml-devel] [PATCH 1/2] um: disable funit-at-a-time for gcc < 4.3

[Richard Weinberger]

Am Sonntag 12 Juni 2011, 13:14:39 schrieb Florian Fainelli:
> From: Nicolas Thill <nico@openwrt.org>
> 
> Building UML with gcc < 4.3 with -funit-at-a-time for i386 causes startup
> crashes, disabling funit-at-a-time works around it.

Can you show me such a crash?
How can I reproduce the issue?

UML works fine on my RHEL5/i386 test box.
gcc 4.1.2 20080704 (Red Hat 4.1.2-46)

Thanks,
//richard

------------------------------------------------------------------------------
EditLive Enterprise is the world's most technically advanced content
authoring tool. Experience the power of Track Changes, Inline Image
Editing and ensure content is compliant with Accessibility Checking.
http://p.sf.net/sfu/ephox-dev2dev
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel

Re: [uml-devel] [PATCH 1/2] um: disable funit-at-a-time for gcc < 4.3

[Florian Fainelli]

On Monday 13 June 2011 01:45:27 Richard Weinberger wrote:
> Am Sonntag 12 Juni 2011, 13:14:39 schrieb Florian Fainelli:
> > From: Nicolas Thill <nico@openwrt.org>
> > 
> > Building UML with gcc < 4.3 with -funit-at-a-time for i386 causes startup
> > crashes, disabling funit-at-a-time works around it.
> 
> Can you show me such a crash?
> How can I reproduce the issue?

Let me get you a test case to reproduce that issue.

> 
> UML works fine on my RHEL5/i386 test box.
> gcc 4.1.2 20080704 (Red Hat 4.1.2-46)
> 
> Thanks,
> //richard
--
Florian

------------------------------------------------------------------------------
EditLive Enterprise is the world's most technically advanced content
authoring tool. Experience the power of Track Changes, Inline Image
Editing and ensure content is compliant with Accessibility Checking.
http://p.sf.net/sfu/ephox-dev2dev
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel