Re: [PATCH 1/4] uml: cow_user.c warning corrections

[Richard Weinberger <richard@nod.at>]

Am Dienstag 05 Juli 2011, 13:38:05 schrieb Geert Uytterhoeven:
> On Tue, Jul 5, 2011 at 13:31, Richard Weinberger <richard@nod.at> wrote:
> > Am Dienstag 05 Juli 2011, 13:10:34 schrieb Vitaliy Ivanov:
> >> On Tue, Jul 5, 2011 at 12:28 PM, Richard Weinberger <richard@nod.at> wrote:
> >> > Am Dienstag 05 Juli 2011, 01:15:41 schrieb Vitaliy Ivanov:
> >> >> From 6201d3e862fca8670b206338dc90303ea0acc77d Mon Sep 17 00:00:00
> >> >> 2001 From: Vitaliy Ivanov <vitalivanov@gmail.com>
> >> >> Date: Tue, 5 Jul 2011 01:57:51 +0300
> >> >> Subject: [PATCH 1/4] uml: cow_user.c warning corrections
> >> >> MIME-Version: 1.0
> >> >> Content-Type: text/plain; charset=UTF-8
> >> >> Content-Transfer-Encoding: 8bit
> >> >> 
> >> >> arch/um/drivers/cow_user.c: In function ‘absolutize’:
> >> >> arch/um/drivers/cow_user.c:189:7: warning: ignoring return value of
> >> >> ‘chdir’, declared with attribute warn_unused_result
> >> > 
> >> > What compiler flags are you using?
> >> > Using the default settings this warning does not show up.
> >> > Most of the "ignoring return value" are totally useless.
> >> 
> >> chdir is defined with warn_unused_result attribute and my gcc on
> >> Ubuntu 11.04 issues warnings.
> >> I don't use any additional flags on compiling UML.
> > 
> > Ah, because of -D_FORTIFY_SOURCE=2, right?
> > Then your patches makes sense.
> 
> I also saw it, with gcc version 4.4.3 (Ubuntu 4.4.3-4ubuntu5).
> I never used FORTIFY_SOURCE.
>

Ubuntu uses FORTIFY_SOURCE per default.

Thanks,
//richard