linux-um archives
 help / color / mirror / Atom feed
From: Richard Weinberger <richard@nod.at>
To: Vitaliy Ivanov <vitalivanov@gmail.com>
Cc: Jeff Dike <jdike@addtoit.com>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
	user-mode-linux-devel@lists.sourceforge.net,
	lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/4] uml: cow_user.c warning corrections
Date: Tue, 5 Jul 2011 13:31:14 +0200	[thread overview]
Message-ID: <201107051331.15504.richard@nod.at> (raw)
In-Reply-To: <CAGTPOqcAETWHG3DEOwDZkMG8_qd-opf90psCi=+U+tYcGV=7=A@mail.gmail.com>

Am Dienstag 05 Juli 2011, 13:10:34 schrieb Vitaliy Ivanov:
> On Tue, Jul 5, 2011 at 12:28 PM, Richard Weinberger <richard@nod.at> wrote:
> > Am Dienstag 05 Juli 2011, 01:15:41 schrieb Vitaliy Ivanov:
> >> From 6201d3e862fca8670b206338dc90303ea0acc77d Mon Sep 17 00:00:00 2001
> >> From: Vitaliy Ivanov <vitalivanov@gmail.com>
> >> Date: Tue, 5 Jul 2011 01:57:51 +0300
> >> Subject: [PATCH 1/4] uml: cow_user.c warning corrections
> >> MIME-Version: 1.0
> >> Content-Type: text/plain; charset=UTF-8
> >> Content-Transfer-Encoding: 8bit
> >> 
> >> arch/um/drivers/cow_user.c: In function ‘absolutize’:
> >> arch/um/drivers/cow_user.c:189:7: warning: ignoring return value of
> >> ‘chdir’, declared with attribute warn_unused_result
> > 
> > What compiler flags are you using?
> > Using the default settings this warning does not show up.
> > Most of the "ignoring return value" are totally useless.
> 
> chdir is defined with warn_unused_result attribute and my gcc on
> Ubuntu 11.04 issues warnings.
> I don't use any additional flags on compiling UML.

Ah, because of -D_FORTIFY_SOURCE=2, right?
Then your patches makes sense.

I'll add it to my queue.

Thanks,
//richard
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


  reply	other threads:[~2011-07-05 11:31 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-04 23:15 [PATCH 1/4] uml: cow_user.c warning corrections Vitaliy Ivanov
2011-07-05  9:28 ` [uml-devel] " Richard Weinberger
2011-07-05 11:10   ` Vitaliy Ivanov
2011-07-05 11:31     ` Richard Weinberger [this message]
2011-07-05 11:38       ` Geert Uytterhoeven
2011-07-05 11:40         ` Richard Weinberger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201107051331.15504.richard@nod.at \
    --to=richard@nod.at \
    --cc=akpm@linux-foundation.org \
    --cc=jdike@addtoit.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    --cc=user-mode-linux-devel@lists.sourceforge.net \
    --cc=vitalivanov@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox