[PATCH 1/4] uml: cow_user.c warning corrections

[PATCH 1/4] uml: cow_user.c warning corrections

[Vitaliy Ivanov]

From 6201d3e862fca8670b206338dc90303ea0acc77d Mon Sep 17 00:00:00 2001
From: Vitaliy Ivanov <vitalivanov@gmail.com>
Date: Tue, 5 Jul 2011 01:57:51 +0300
Subject: [PATCH 1/4] uml: cow_user.c warning corrections
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

arch/um/drivers/cow_user.c: In function ‘absolutize’:
arch/um/drivers/cow_user.c:189:7: warning: ignoring return value of ‘chdir’, declared with attribute warn_unused_result

Signed-off-by: Vitaliy Ivanov <vitalivanov@gmail.com>
---
 arch/um/drivers/cow_user.c |    6 +++++-
 1 files changed, 5 insertions(+), 1 deletions(-)

diff --git a/arch/um/drivers/cow_user.c b/arch/um/drivers/cow_user.c
index 93f227a..9cbb426 100644
--- a/arch/um/drivers/cow_user.c
+++ b/arch/um/drivers/cow_user.c
@@ -186,7 +186,11 @@ static int absolutize(char *to, int size, char *from)
 		strcat(to, "/");
 		strcat(to, from);
 	}
-	chdir(save_cwd);
+	if (chdir(save_cwd)) {
+		cow_printf("absolutize : Can't cd to '%s' - "
+			   "errno = %d\n", save_cwd, errno);
+		return -1;
+	}
 	return 0;
 }
 
-- 
1.7.4.1



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [uml-devel] [PATCH 1/4] uml: cow_user.c warning corrections

[Richard Weinberger]

Am Dienstag 05 Juli 2011, 01:15:41 schrieb Vitaliy Ivanov:
> From 6201d3e862fca8670b206338dc90303ea0acc77d Mon Sep 17 00:00:00 2001
> From: Vitaliy Ivanov <vitalivanov@gmail.com>
> Date: Tue, 5 Jul 2011 01:57:51 +0300
> Subject: [PATCH 1/4] uml: cow_user.c warning corrections
> MIME-Version: 1.0
> Content-Type: text/plain; charset=UTF-8
> Content-Transfer-Encoding: 8bit
> 
> arch/um/drivers/cow_user.c: In function ‘absolutize’:
> arch/um/drivers/cow_user.c:189:7: warning: ignoring return value of
> ‘chdir’, declared with attribute warn_unused_result

What compiler flags are you using?
Using the default settings this warning does not show up.
Most of the "ignoring return value" are totally useless.

> Signed-off-by: Vitaliy Ivanov <vitalivanov@gmail.com>
> ---
>  arch/um/drivers/cow_user.c |    6 +++++-
>  1 files changed, 5 insertions(+), 1 deletions(-)
> 
> diff --git a/arch/um/drivers/cow_user.c b/arch/um/drivers/cow_user.c
> index 93f227a..9cbb426 100644
> --- a/arch/um/drivers/cow_user.c
> +++ b/arch/um/drivers/cow_user.c
> @@ -186,7 +186,11 @@ static int absolutize(char *to, int size, char *from)
>  		strcat(to, "/");
>  		strcat(to, from);
>  	}
> -	chdir(save_cwd);
> +	if (chdir(save_cwd)) {
> +		cow_printf("absolutize : Can't cd to '%s' - "
> +			   "errno = %d\n", save_cwd, errno);
> +		return -1;
> +	}

I don't think that this check is needed nor chdir() to save_cwd can fail.
Because we obtain it by calling getcwd() and never change it...

Thanks,
//richard

------------------------------------------------------------------------------
All of the data generated in your IT infrastructure is seriously valuable.
Why? It contains a definitive record of application performance, security 
threats, fraudulent activity, and more. Splunk takes this data and makes 
sense of it. IT sense. And common sense.
http://p.sf.net/sfu/splunk-d2d-c2
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel

Re: [PATCH 1/4] uml: cow_user.c warning corrections

[Vitaliy Ivanov]

On Tue, Jul 5, 2011 at 12:28 PM, Richard Weinberger <richard@nod.at> wrote:
> Am Dienstag 05 Juli 2011, 01:15:41 schrieb Vitaliy Ivanov:
>> From 6201d3e862fca8670b206338dc90303ea0acc77d Mon Sep 17 00:00:00 2001
>> From: Vitaliy Ivanov <vitalivanov@gmail.com>
>> Date: Tue, 5 Jul 2011 01:57:51 +0300
>> Subject: [PATCH 1/4] uml: cow_user.c warning corrections
>> MIME-Version: 1.0
>> Content-Type: text/plain; charset=UTF-8
>> Content-Transfer-Encoding: 8bit
>>
>> arch/um/drivers/cow_user.c: In function ‘absolutize’:
>> arch/um/drivers/cow_user.c:189:7: warning: ignoring return value of
>> ‘chdir’, declared with attribute warn_unused_result
>
> What compiler flags are you using?
> Using the default settings this warning does not show up.
> Most of the "ignoring return value" are totally useless.

chdir is defined with warn_unused_result attribute and my gcc on
Ubuntu 11.04 issues warnings.
I don't use any additional flags on compiling UML.

Vitaliy
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 1/4] uml: cow_user.c warning corrections

[Richard Weinberger]

Am Dienstag 05 Juli 2011, 13:10:34 schrieb Vitaliy Ivanov:
> On Tue, Jul 5, 2011 at 12:28 PM, Richard Weinberger <richard@nod.at> wrote:
> > Am Dienstag 05 Juli 2011, 01:15:41 schrieb Vitaliy Ivanov:
> >> From 6201d3e862fca8670b206338dc90303ea0acc77d Mon Sep 17 00:00:00 2001
> >> From: Vitaliy Ivanov <vitalivanov@gmail.com>
> >> Date: Tue, 5 Jul 2011 01:57:51 +0300
> >> Subject: [PATCH 1/4] uml: cow_user.c warning corrections
> >> MIME-Version: 1.0
> >> Content-Type: text/plain; charset=UTF-8
> >> Content-Transfer-Encoding: 8bit
> >> 
> >> arch/um/drivers/cow_user.c: In function ‘absolutize’:
> >> arch/um/drivers/cow_user.c:189:7: warning: ignoring return value of
> >> ‘chdir’, declared with attribute warn_unused_result
> > 
> > What compiler flags are you using?
> > Using the default settings this warning does not show up.
> > Most of the "ignoring return value" are totally useless.
> 
> chdir is defined with warn_unused_result attribute and my gcc on
> Ubuntu 11.04 issues warnings.
> I don't use any additional flags on compiling UML.

Ah, because of -D_FORTIFY_SOURCE=2, right?
Then your patches makes sense.

I'll add it to my queue.

Thanks,
//richard
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 1/4] uml: cow_user.c warning corrections

[Geert Uytterhoeven]

On Tue, Jul 5, 2011 at 13:31, Richard Weinberger <richard@nod.at> wrote:
> Am Dienstag 05 Juli 2011, 13:10:34 schrieb Vitaliy Ivanov:
>> On Tue, Jul 5, 2011 at 12:28 PM, Richard Weinberger <richard@nod.at> wrote:
>> > Am Dienstag 05 Juli 2011, 01:15:41 schrieb Vitaliy Ivanov:
>> >> From 6201d3e862fca8670b206338dc90303ea0acc77d Mon Sep 17 00:00:00 2001
>> >> From: Vitaliy Ivanov <vitalivanov@gmail.com>
>> >> Date: Tue, 5 Jul 2011 01:57:51 +0300
>> >> Subject: [PATCH 1/4] uml: cow_user.c warning corrections
>> >> MIME-Version: 1.0
>> >> Content-Type: text/plain; charset=UTF-8
>> >> Content-Transfer-Encoding: 8bit
>> >>
>> >> arch/um/drivers/cow_user.c: In function ‘absolutize’:
>> >> arch/um/drivers/cow_user.c:189:7: warning: ignoring return value of
>> >> ‘chdir’, declared with attribute warn_unused_result
>> >
>> > What compiler flags are you using?
>> > Using the default settings this warning does not show up.
>> > Most of the "ignoring return value" are totally useless.
>>
>> chdir is defined with warn_unused_result attribute and my gcc on
>> Ubuntu 11.04 issues warnings.
>> I don't use any additional flags on compiling UML.
>
> Ah, because of -D_FORTIFY_SOURCE=2, right?
> Then your patches makes sense.

I also saw it, with gcc version 4.4.3 (Ubuntu 4.4.3-4ubuntu5).
I never used FORTIFY_SOURCE.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH 1/4] uml: cow_user.c warning corrections

[Richard Weinberger]

Am Dienstag 05 Juli 2011, 13:38:05 schrieb Geert Uytterhoeven:
> On Tue, Jul 5, 2011 at 13:31, Richard Weinberger <richard@nod.at> wrote:
> > Am Dienstag 05 Juli 2011, 13:10:34 schrieb Vitaliy Ivanov:
> >> On Tue, Jul 5, 2011 at 12:28 PM, Richard Weinberger <richard@nod.at> wrote:
> >> > Am Dienstag 05 Juli 2011, 01:15:41 schrieb Vitaliy Ivanov:
> >> >> From 6201d3e862fca8670b206338dc90303ea0acc77d Mon Sep 17 00:00:00
> >> >> 2001 From: Vitaliy Ivanov <vitalivanov@gmail.com>
> >> >> Date: Tue, 5 Jul 2011 01:57:51 +0300
> >> >> Subject: [PATCH 1/4] uml: cow_user.c warning corrections
> >> >> MIME-Version: 1.0
> >> >> Content-Type: text/plain; charset=UTF-8
> >> >> Content-Transfer-Encoding: 8bit
> >> >> 
> >> >> arch/um/drivers/cow_user.c: In function ‘absolutize’:
> >> >> arch/um/drivers/cow_user.c:189:7: warning: ignoring return value of
> >> >> ‘chdir’, declared with attribute warn_unused_result
> >> > 
> >> > What compiler flags are you using?
> >> > Using the default settings this warning does not show up.
> >> > Most of the "ignoring return value" are totally useless.
> >> 
> >> chdir is defined with warn_unused_result attribute and my gcc on
> >> Ubuntu 11.04 issues warnings.
> >> I don't use any additional flags on compiling UML.
> > 
> > Ah, because of -D_FORTIFY_SOURCE=2, right?
> > Then your patches makes sense.
> 
> I also saw it, with gcc version 4.4.3 (Ubuntu 4.4.3-4ubuntu5).
> I never used FORTIFY_SOURCE.
>

Ubuntu uses FORTIFY_SOURCE per default.

Thanks,
//richard