* [PATCH] x86/um/vdso: Drop implicit common-page-size linker flag
@ 2018-12-10 22:27 ndesaulniers
2018-12-11 12:46 ` Richard Weinberger
0 siblings, 1 reply; 2+ messages in thread
From: ndesaulniers @ 2018-12-10 22:27 UTC (permalink / raw)
To: jdike, richard
Cc: linux-um, x86, Nick Desaulniers, linux-kernel, Masahiro Yamada,
Ingo Molnar, Borislav Petkov, H. Peter Anvin, Thomas Gleixner
GNU linker's -z common-page-size's default value is based on the target
architecture. arch/x86/entry/vdso/Makefile sets it to the architecture
default, which is implicit and redundant. Drop it.
Link: https://lkml.kernel.org/r/20181206191231.192355-1-ndesaulniers@google.com
Signed-off-by: Nick Desaulniers <ndesaulniers@google.com>
---
arch/x86/um/vdso/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/um/vdso/Makefile b/arch/x86/um/vdso/Makefile
index 822ccdba93ad..bf94060fc06f 100644
--- a/arch/x86/um/vdso/Makefile
+++ b/arch/x86/um/vdso/Makefile
@@ -26,7 +26,7 @@ targets += vdso.so vdso.so.dbg vdso.lds $(vobjs-y)
CPPFLAGS_vdso.lds += -P -C
VDSO_LDFLAGS_vdso.lds = -m64 -Wl,-soname=linux-vdso.so.1 \
- -Wl,-z,max-page-size=4096 -Wl,-z,common-page-size=4096
+ -Wl,-z,max-page-size=4096
$(obj)/vdso.o: $(src)/vdso.S $(obj)/vdso.so
--
2.20.0.rc2.403.gdbc3b29805-goog
_______________________________________________
linux-um mailing list
linux-um@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-um
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] x86/um/vdso: Drop implicit common-page-size linker flag
2018-12-10 22:27 [PATCH] x86/um/vdso: Drop implicit common-page-size linker flag ndesaulniers
@ 2018-12-11 12:46 ` Richard Weinberger
0 siblings, 0 replies; 2+ messages in thread
From: Richard Weinberger @ 2018-12-11 12:46 UTC (permalink / raw)
To: ndesaulniers
Cc: jdike, x86, linux-um, linux-kernel, Masahiro Yamada, Ingo Molnar,
Borislav Petkov, H. Peter Anvin, Thomas Gleixner
Am Montag, 10. Dezember 2018, 23:27:16 CET schrieb ndesaulniers@google.com:
> GNU linker's -z common-page-size's default value is based on the target
> architecture. arch/x86/entry/vdso/Makefile sets it to the architecture
> default, which is implicit and redundant. Drop it.
>
> Link: https://lkml.kernel.org/r/20181206191231.192355-1-ndesaulniers@google.com
> Signed-off-by: Nick Desaulniers <ndesaulniers@google.com>
> ---
> arch/x86/um/vdso/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/x86/um/vdso/Makefile b/arch/x86/um/vdso/Makefile
> index 822ccdba93ad..bf94060fc06f 100644
> --- a/arch/x86/um/vdso/Makefile
> +++ b/arch/x86/um/vdso/Makefile
> @@ -26,7 +26,7 @@ targets += vdso.so vdso.so.dbg vdso.lds $(vobjs-y)
> CPPFLAGS_vdso.lds += -P -C
>
> VDSO_LDFLAGS_vdso.lds = -m64 -Wl,-soname=linux-vdso.so.1 \
> - -Wl,-z,max-page-size=4096 -Wl,-z,common-page-size=4096
> + -Wl,-z,max-page-size=4096
Acked-by: Richard Weinberger <richard@nod.at>
Thanks,
//richard
_______________________________________________
linux-um mailing list
linux-um@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-um
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-12-11 12:47 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-12-10 22:27 [PATCH] x86/um/vdso: Drop implicit common-page-size linker flag ndesaulniers
2018-12-11 12:46 ` Richard Weinberger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox