linux-um archives
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Glenn Washburn <development@efficientek.com>
Cc: Jan Kiszka <jan.kiszka@siemens.com>,
	Kieran Bingham <kbingham@kernel.org>,
	linux-kernel@vger.kernel.org,
	linux-um <linux-um@lists.infradead.org>,
	Richard Weinberger <richard@nod.at>,
	Johannes Berg <johannes@sipsolutions.net>,
	Anton Ivanov <anton.ivanov@kot-begemot.co.uk>
Subject: Re: [PATCH v2 0/2] GDB: Support getting current task struct in UML
Date: Thu, 23 Feb 2023 13:14:02 -0800	[thread overview]
Message-ID: <20230223131402.6d6a662f76348b14574121d3@linux-foundation.org> (raw)
In-Reply-To: <cover.1676532759.git.development@efficientek.com>

On Fri, 17 Feb 2023 19:11:52 -0600 Glenn Washburn <development@efficientek.com> wrote:

> Added suggestions from Jan.
> 
> Glenn
> 
> Glenn Washburn (2):
>   scripts/gdb: Correct indentation in get_current_task
>   scripts/gdb: Support getting current task struct in UML
> 

For some reason I get a bunch of rejects when applying these on top of
the latest patchpile.  Please check my end result:

def get_current_task(cpu):
    task_ptr_type = task_type.get_type().pointer()

    if utils.is_target_arch("x86"):
        if gdb.lookup_global_symbol("cpu_tasks"):
            # This is a UML kernel, which stores the current task
            # differently than other x86 sub architectures
            var_ptr = gdb.parse_and_eval("(struct task_struct *)cpu_tasks[0].task")
            return var_ptr.dereference()
        else:
            var_ptr = gdb.parse_and_eval("&current_task")
            return per_cpu(var_ptr, cpu).dereference()
    elif utils.is_target_arch("aarch64"):
        current_task_addr = gdb.parse_and_eval("$SP_EL0")
        if((current_task_addr >> 63) != 0):
            current_task = current_task_addr.cast(task_ptr_type)
            return current_task.dereference()
        else:
            raise gdb.GdbError("Sorry, obtaining the current task is not allowed "
                                "while running in userspace(EL0)")
    else:
        raise gdb.GdbError("Sorry, obtaining the current task is not yet "
                           "supported with this arch")




_______________________________________________
linux-um mailing list
linux-um@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-um

  parent reply	other threads:[~2023-02-23 21:14 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-16  7:37 [PATCH v2 0/2] GDB: Support getting current task struct in UML Glenn Washburn
2023-02-16  7:37 ` [PATCH v2 1/2] scripts/gdb: Correct indentation in get_current_task Glenn Washburn
2023-02-18  1:11   ` Glenn Washburn
2023-02-16  7:37 ` [PATCH v2 2/2] scripts/gdb: Support getting current task struct in UML Glenn Washburn
2023-02-18  1:11   ` Glenn Washburn
2023-02-16  7:51 ` [PATCH v2 0/2] GDB: " Jan Kiszka
2023-02-16 22:40   ` Andrew Morton
2023-02-16 22:54     ` Richard Weinberger
2023-02-16 23:33       ` Andrew Morton
2023-02-17 10:14         ` Geert Uytterhoeven
2023-02-17 21:56           ` Glenn Washburn
2023-02-17 22:21             ` Andrew Morton
2023-02-18  1:11 ` Glenn Washburn
2023-02-23 21:14 ` Andrew Morton [this message]
2023-02-26  6:47   ` Glenn Washburn
2023-02-26 19:35     ` Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230223131402.6d6a662f76348b14574121d3@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=anton.ivanov@kot-begemot.co.uk \
    --cc=development@efficientek.com \
    --cc=jan.kiszka@siemens.com \
    --cc=johannes@sipsolutions.net \
    --cc=kbingham@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-um@lists.infradead.org \
    --cc=richard@nod.at \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox