* [PATCH 37/79] hostfs: switch to new ctime accessors
[not found] ` <20230621144735.55953-1-jlayton@kernel.org>
@ 2023-06-21 14:45 ` Jeff Layton
0 siblings, 0 replies; 3+ messages in thread
From: Jeff Layton @ 2023-06-21 14:45 UTC (permalink / raw)
To: Christian Brauner, Richard Weinberger, Anton Ivanov,
Johannes Berg
Cc: Al Viro, Jan Kara, linux-um, linux-kernel
In later patches, we're going to change how the ctime.tv_nsec field is
utilized. Switch to using accessor functions instead of raw accesses of
inode->i_ctime.
Signed-off-by: Jeff Layton <jlayton@kernel.org>
---
fs/hostfs/hostfs_kern.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/fs/hostfs/hostfs_kern.c b/fs/hostfs/hostfs_kern.c
index 46387090eb76..2248a2e599a7 100644
--- a/fs/hostfs/hostfs_kern.c
+++ b/fs/hostfs/hostfs_kern.c
@@ -517,8 +517,8 @@ static int hostfs_inode_update(struct inode *ino, const struct hostfs_stat *st)
(struct timespec64){ st->atime.tv_sec, st->atime.tv_nsec };
ino->i_mtime =
(struct timespec64){ st->mtime.tv_sec, st->mtime.tv_nsec };
- ino->i_ctime =
- (struct timespec64){ st->ctime.tv_sec, st->ctime.tv_nsec };
+ inode_ctime_set(ino,
+ (struct timespec64){ st->ctime.tv_sec, st->ctime.tv_nsec });
ino->i_size = st->size;
ino->i_blocks = st->blocks;
return 0;
--
2.41.0
_______________________________________________
linux-um mailing list
linux-um@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-um
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 01/79] fs: add ctime accessors infrastructure
[not found] ` <20230621144507.55591-2-jlayton@kernel.org>
@ 2023-07-12 15:31 ` Randy Dunlap
2023-07-12 15:34 ` Christian Brauner
0 siblings, 1 reply; 3+ messages in thread
From: Randy Dunlap @ 2023-07-12 15:31 UTC (permalink / raw)
To: Jeff Layton, linux-kernel@vger.kernel.org,
Linux FS-devel Mailing List, linux-um
Hi Jeff,
On arch/um/, (subarch i386 or x86_64), hostfs build fails with:
../fs/hostfs/hostfs_kern.c:520:36: error: incompatible type for arg
ument 2 of 'inode_set_ctime_to_ts'
../include/linux/fs.h:1499:73: note: expected 'struct timespec64' b
ut argument is of type 'const struct hostfs_timespec *'
--
~Randy
_______________________________________________
linux-um mailing list
linux-um@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-um
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 01/79] fs: add ctime accessors infrastructure
2023-07-12 15:31 ` [PATCH 01/79] fs: add ctime accessors infrastructure Randy Dunlap
@ 2023-07-12 15:34 ` Christian Brauner
0 siblings, 0 replies; 3+ messages in thread
From: Christian Brauner @ 2023-07-12 15:34 UTC (permalink / raw)
To: Randy Dunlap
Cc: Jeff Layton, linux-kernel@vger.kernel.org,
Linux FS-devel Mailing List, linux-um
On Wed, Jul 12, 2023 at 08:31:55AM -0700, Randy Dunlap wrote:
> Hi Jeff,
>
> On arch/um/, (subarch i386 or x86_64), hostfs build fails with:
>
> ../fs/hostfs/hostfs_kern.c:520:36: error: incompatible type for arg
> ument 2 of 'inode_set_ctime_to_ts'
> ../include/linux/fs.h:1499:73: note: expected 'struct timespec64' b
> ut argument is of type 'const struct hostfs_timespec *'
Thanks for notifying us! We fixed this earlier today. The vfs.ctime
branch has been updated with the fix folded into the hostfs patch.
_______________________________________________
linux-um mailing list
linux-um@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-um
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-07-12 15:34 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20230621144507.55591-1-jlayton@kernel.org>
[not found] ` <20230621144735.55953-1-jlayton@kernel.org>
2023-06-21 14:45 ` [PATCH 37/79] hostfs: switch to new ctime accessors Jeff Layton
[not found] ` <20230621144507.55591-2-jlayton@kernel.org>
2023-07-12 15:31 ` [PATCH 01/79] fs: add ctime accessors infrastructure Randy Dunlap
2023-07-12 15:34 ` Christian Brauner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox