* [PATCH] samples: disable CONFIG_SAMPLES for UML
@ 2018-09-18 3:58 Masahiro Yamada
2018-09-18 8:21 ` Richard Weinberger
2018-10-09 14:56 ` Masahiro Yamada
0 siblings, 2 replies; 6+ messages in thread
From: Masahiro Yamada @ 2018-09-18 3:58 UTC (permalink / raw)
To: linux-kbuild
Cc: Arnd Bergmann, Richard Weinberger, Jeff Dike, linux-um,
linux-kernel, Bjorn Andersson, David Howells, Masahiro Yamada,
Alex Williamson, Gerd Hoffmann, Andy Gross
Some samples require headers installation, so commit 3fca1700c4c3
("kbuild: make samples really depend on headers_install") added
such dependency in the top Makefile. However, UML fails to build
with CONFIG_SAMPLES=y because UML does not support headers_install.
Fixes: 3fca1700c4c3 ("kbuild: make samples really depend on headers_install")
Reported-by: Kees Cook <keescook@chromium.org>
Cc: David Howells <dhowells@redhat.com>
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
---
samples/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/samples/Kconfig b/samples/Kconfig
index bd133ef..ad1ec701 100644
--- a/samples/Kconfig
+++ b/samples/Kconfig
@@ -1,5 +1,6 @@
menuconfig SAMPLES
bool "Sample kernel code"
+ depends on !UML
help
You can build and test sample kernel code here.
--
2.7.4
_______________________________________________
linux-um mailing list
linux-um@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-um
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] samples: disable CONFIG_SAMPLES for UML
2018-09-18 3:58 [PATCH] samples: disable CONFIG_SAMPLES for UML Masahiro Yamada
@ 2018-09-18 8:21 ` Richard Weinberger
2018-09-18 8:28 ` Anton Ivanov
2018-09-19 6:58 ` Masahiro Yamada
2018-10-09 14:56 ` Masahiro Yamada
1 sibling, 2 replies; 6+ messages in thread
From: Richard Weinberger @ 2018-09-18 8:21 UTC (permalink / raw)
To: Masahiro Yamada
Cc: Arnd Bergmann, linux-kbuild, Jeff Dike, linux-um, linux-kernel,
Bjorn Andersson, David Howells, Alex Williamson, Gerd Hoffmann,
Andy Gross
Am Dienstag, 18. September 2018, 05:58:33 CEST schrieb Masahiro Yamada:
> Some samples require headers installation, so commit 3fca1700c4c3
> ("kbuild: make samples really depend on headers_install") added
> such dependency in the top Makefile. However, UML fails to build
> with CONFIG_SAMPLES=y because UML does not support headers_install.
>
> Fixes: 3fca1700c4c3 ("kbuild: make samples really depend on headers_install")
> Reported-by: Kees Cook <keescook@chromium.org>
> Cc: David Howells <dhowells@redhat.com>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Is there anything UML can do better?
Not sure whether an arch like is supposed to install headers at all,
I guess no. :)
Thanks,
//richard
_______________________________________________
linux-um mailing list
linux-um@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-um
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] samples: disable CONFIG_SAMPLES for UML
2018-09-18 8:21 ` Richard Weinberger
@ 2018-09-18 8:28 ` Anton Ivanov
2018-09-19 6:58 ` Masahiro Yamada
1 sibling, 0 replies; 6+ messages in thread
From: Anton Ivanov @ 2018-09-18 8:28 UTC (permalink / raw)
To: linux-um
On 09/18/18 09:21, Richard Weinberger wrote:
> Am Dienstag, 18. September 2018, 05:58:33 CEST schrieb Masahiro Yamada:
>> Some samples require headers installation, so commit 3fca1700c4c3
>> ("kbuild: make samples really depend on headers_install") added
>> such dependency in the top Makefile. However, UML fails to build
>> with CONFIG_SAMPLES=y because UML does not support headers_install.
>>
>> Fixes: 3fca1700c4c3 ("kbuild: make samples really depend on headers_install")
>> Reported-by: Kees Cook <keescook@chromium.org>
>> Cc: David Howells <dhowells@redhat.com>
>> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> Is there anything UML can do better?
> Not sure whether an arch like is supposed to install headers at all,
> I guess no. :)
As a side note.
OpenWRT/LEDE patches for their build tree patch UML to do so when
building UML. IMHO it is a hack, but it works.
A.
>
> Thanks,
> //richard
>
>
>
> _______________________________________________
> linux-um mailing list
> linux-um@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-um
>
--
Anton R. Ivanov
Cambridge Greys Limited, England and Wales company No 10273661
http://www.cambridgegreys.com/
_______________________________________________
linux-um mailing list
linux-um@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-um
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] samples: disable CONFIG_SAMPLES for UML
2018-09-18 8:21 ` Richard Weinberger
2018-09-18 8:28 ` Anton Ivanov
@ 2018-09-19 6:58 ` Masahiro Yamada
2018-09-28 6:55 ` Masahiro Yamada
1 sibling, 1 reply; 6+ messages in thread
From: Masahiro Yamada @ 2018-09-19 6:58 UTC (permalink / raw)
To: Richard Weinberger
Cc: Linux Kbuild mailing list, Jeff Dike, linux-um, David Howells,
Bjorn Andersson, Arnd Bergmann, Linux Kernel Mailing List,
Andy Gross, Alex Williamson, Gerd Hoffmann
Hi.
2018-09-18 17:21 GMT+09:00 Richard Weinberger <richard@nod.at>:
> Am Dienstag, 18. September 2018, 05:58:33 CEST schrieb Masahiro Yamada:
>> Some samples require headers installation, so commit 3fca1700c4c3
>> ("kbuild: make samples really depend on headers_install") added
>> such dependency in the top Makefile. However, UML fails to build
>> with CONFIG_SAMPLES=y because UML does not support headers_install.
>>
>> Fixes: 3fca1700c4c3 ("kbuild: make samples really depend on headers_install")
>> Reported-by: Kees Cook <keescook@chromium.org>
>> Cc: David Howells <dhowells@redhat.com>
>> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
>
> Is there anything UML can do better?
> Not sure whether an arch like is supposed to install headers at all,
> I guess no. :)
I just thought suppressing CONFIG_SAMPLES was a big hammer.
We could install host-arch headers for UML if we like,
but I am not sure whether is is sensible...
Wait for comments in case somebody has a better solution.
--
Best Regards
Masahiro Yamada
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] samples: disable CONFIG_SAMPLES for UML
2018-09-19 6:58 ` Masahiro Yamada
@ 2018-09-28 6:55 ` Masahiro Yamada
0 siblings, 0 replies; 6+ messages in thread
From: Masahiro Yamada @ 2018-09-28 6:55 UTC (permalink / raw)
To: Richard Weinberger
Cc: Linux Kbuild mailing list, Jeff Dike, linux-um, David Howells,
Bjorn Andersson, Arnd Bergmann, Linux Kernel Mailing List,
Andy Gross, Alex Williamson, Gerd Hoffmann
2018年9月19日(水) 15:58 Masahiro Yamada <yamada.masahiro@socionext.com>:
>
> Hi.
>
> 2018-09-18 17:21 GMT+09:00 Richard Weinberger <richard@nod.at>:
> > Am Dienstag, 18. September 2018, 05:58:33 CEST schrieb Masahiro Yamada:
> >> Some samples require headers installation, so commit 3fca1700c4c3
> >> ("kbuild: make samples really depend on headers_install") added
> >> such dependency in the top Makefile. However, UML fails to build
> >> with CONFIG_SAMPLES=y because UML does not support headers_install.
> >>
> >> Fixes: 3fca1700c4c3 ("kbuild: make samples really depend on headers_install")
> >> Reported-by: Kees Cook <keescook@chromium.org>
> >> Cc: David Howells <dhowells@redhat.com>
> >> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> >
> > Is there anything UML can do better?
> > Not sure whether an arch like is supposed to install headers at all,
> > I guess no. :)
>
> I just thought suppressing CONFIG_SAMPLES was a big hammer.
>
> We could install host-arch headers for UML if we like,
> but I am not sure whether is is sensible...
>
> Wait for comments in case somebody has a better solution.
>
I started to think this is a wrong hack.
I posted a different solution:
https://patchwork.kernel.org/patch/10619043/
--
Best Regards
Masahiro Yamada
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] samples: disable CONFIG_SAMPLES for UML
2018-09-18 3:58 [PATCH] samples: disable CONFIG_SAMPLES for UML Masahiro Yamada
2018-09-18 8:21 ` Richard Weinberger
@ 2018-10-09 14:56 ` Masahiro Yamada
1 sibling, 0 replies; 6+ messages in thread
From: Masahiro Yamada @ 2018-10-09 14:56 UTC (permalink / raw)
To: Linux Kbuild mailing list
Cc: Jeff Dike, Richard Weinberger, linux-um, David Howells,
Bjorn Andersson, Arnd Bergmann, Linux Kernel Mailing List,
Andy Gross, Alex Williamson, Gerd Hoffmann
On Tue, Sep 18, 2018 at 12:59 PM Masahiro Yamada
<yamada.masahiro@socionext.com> wrote:
>
> Some samples require headers installation, so commit 3fca1700c4c3
> ("kbuild: make samples really depend on headers_install") added
> such dependency in the top Makefile. However, UML fails to build
> with CONFIG_SAMPLES=y because UML does not support headers_install.
>
> Fixes: 3fca1700c4c3 ("kbuild: make samples really depend on headers_install")
> Reported-by: Kees Cook <keescook@chromium.org>
> Cc: David Howells <dhowells@redhat.com>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> ---
I did not get any more comment.
I applied to linux-kbuild/fixes.
>
> samples/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/samples/Kconfig b/samples/Kconfig
> index bd133ef..ad1ec701 100644
> --- a/samples/Kconfig
> +++ b/samples/Kconfig
> @@ -1,5 +1,6 @@
> menuconfig SAMPLES
> bool "Sample kernel code"
> + depends on !UML
> help
> You can build and test sample kernel code here.
>
> --
> 2.7.4
>
--
Best Regards
Masahiro Yamada
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-10-09 14:56 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-09-18 3:58 [PATCH] samples: disable CONFIG_SAMPLES for UML Masahiro Yamada
2018-09-18 8:21 ` Richard Weinberger
2018-09-18 8:28 ` Anton Ivanov
2018-09-19 6:58 ` Masahiro Yamada
2018-09-28 6:55 ` Masahiro Yamada
2018-10-09 14:56 ` Masahiro Yamada
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox