From: Johannes Berg <johannes@sipsolutions.net>
To: Anton Ivanov <anton.ivanov@kot-begemot.co.uk>,
linux-um@lists.infradead.org
Subject: Re: [PATCH 7/7] um: simplify IRQ handling code
Date: Wed, 02 Dec 2020 12:58:36 +0100 [thread overview]
Message-ID: <2829ed07f8d72e680d40b01e6fa9d7f91e18262a.camel@sipsolutions.net> (raw)
In-Reply-To: <e3aca9bc-9c01-179e-8755-48cd8c7ad4c8@kot-begemot.co.uk>
On Wed, 2020-12-02 at 11:56 +0000, Anton Ivanov wrote:
>
> > Also, we probably should disable SIGIO if the IRQ is freed, otherwise
> > the FD can keep interrupting us but we don't find anything in the epoll
> > set ... But again, a separate cleanup?
>
> I think that deleting the fd from the set should stop that.
It doesn't. We'd have to separately call ignore_sigio_fd(), but we only
do that in deactivate_fd(), not in any of the other code paths ...
> Let me think on it. It was clearly being held together by duck tape
> and baling wire and it needs fixing. You got most of it which is
> grand, we just need to finish it.
Indeed.
Will send out this set again with the fix in a few minutes.
johannes
_______________________________________________
linux-um mailing list
linux-um@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-um
next prev parent reply other threads:[~2020-12-02 11:58 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-23 19:56 [PATCH 0/7 um: IRQ handling cleanups Johannes Berg
2020-11-23 19:56 ` [PATCH 1/7] um: support dynamic IRQ allocation Johannes Berg
2020-11-30 11:26 ` Anton Ivanov
2020-11-23 19:56 ` [PATCH 2/7] um: virtio: use " Johannes Berg
2020-11-30 13:45 ` Anton Ivanov
2020-11-23 19:56 ` [PATCH 3/7] um: clean up alarm IRQ chip name Johannes Berg
2020-11-30 13:54 ` Anton Ivanov
2020-11-23 19:56 ` [PATCH 4/7] um: irq: clean up and rename struct irq_fd Johannes Berg
2020-11-30 14:01 ` Anton Ivanov
2020-11-23 19:56 ` [PATCH 5/7] um: irq: reduce irq_reg allocation Johannes Berg
2020-11-23 19:56 ` [PATCH 6/7] um: remove IRQ_NONE type Johannes Berg
2020-11-30 14:31 ` Anton Ivanov
2020-11-23 19:56 ` [PATCH 7/7] um: simplify IRQ handling code Johannes Berg
2020-11-24 21:50 ` Anton Ivanov
2020-11-24 21:58 ` Johannes Berg
2020-11-24 22:36 ` Anton Ivanov
2020-11-30 12:00 ` Johannes Berg
2020-11-30 13:40 ` Anton Ivanov
2020-11-30 16:30 ` Anton Ivanov
2020-12-01 20:15 ` Johannes Berg
2020-12-02 9:03 ` Anton Ivanov
2020-12-02 11:29 ` Johannes Berg
2020-12-02 11:31 ` Anton Ivanov
2020-12-02 11:32 ` Johannes Berg
2020-12-02 11:56 ` Anton Ivanov
2020-12-02 11:58 ` Johannes Berg [this message]
2020-12-02 11:43 ` Johannes Berg
2020-12-02 11:49 ` Johannes Berg
2020-12-02 11:54 ` Johannes Berg
2020-12-02 11:58 ` Anton Ivanov
2020-11-24 8:14 ` [PATCH 0/7 um: IRQ handling cleanups Anton Ivanov
2020-11-24 8:55 ` Johannes Berg
2020-11-24 8:58 ` Johannes Berg
2020-11-24 9:06 ` Anton Ivanov
2020-11-24 16:34 ` Anton Ivanov
2020-11-24 16:39 ` Johannes Berg
2020-11-24 16:42 ` Anton Ivanov
2020-11-24 16:45 ` Anton Ivanov
2020-11-24 16:46 ` Johannes Berg
2020-11-24 17:07 ` Anton Ivanov
2020-11-24 18:32 ` Johannes Berg
2020-11-24 21:11 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2829ed07f8d72e680d40b01e6fa9d7f91e18262a.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=anton.ivanov@kot-begemot.co.uk \
--cc=linux-um@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox