From: Johannes Berg <johannes@sipsolutions.net>
To: Anton Ivanov <anton.ivanov@kot-begemot.co.uk>,
linux-um@lists.infradead.org
Subject: Re: [PATCH 7/7] um: simplify IRQ handling code
Date: Wed, 02 Dec 2020 12:29:42 +0100 [thread overview]
Message-ID: <6cbfb799d0889dc2d34d7c773a42305d025c615b.camel@sipsolutions.net> (raw)
In-Reply-To: <02516224-6caf-c947-3410-0fcdc6e7204e@kot-begemot.co.uk>
On Wed, 2020-12-02 at 09:03 +0000, Anton Ivanov wrote:
>
> raw sockets on a vEth pair.
>
> I avoid tap as it does not exercise the full vector IO code for now.
> One day I will find a way to extract from the kernel the underlying
> socket which tap uses internally and it will become 100% equivalent to
> the other transports.
OK, thanks.
> > > Try to ifup/ifdown the vecX interface inside the UML.
> > >
> > > With master it works fine. With this patch it fails.
> > How does it fail?
>
> ------------[ cut here ]------------
> WARNING: CPU: 0 PID: 401 at arch/um/kernel/irq.c:177 um_request_irq+0xff/0x22e
Hm, interesting. So that means the IRQ was still busy after
vector_net_close()?
I'm still digging and trying to build a test case, but if you have a
test case at hand .. I wonder if IRQ aliasing happened - if you remove
the "goto out;" in free_irq_by_irq_and_dev(), does that help?
johannes
_______________________________________________
linux-um mailing list
linux-um@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-um
next prev parent reply other threads:[~2020-12-02 11:30 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-23 19:56 [PATCH 0/7 um: IRQ handling cleanups Johannes Berg
2020-11-23 19:56 ` [PATCH 1/7] um: support dynamic IRQ allocation Johannes Berg
2020-11-30 11:26 ` Anton Ivanov
2020-11-23 19:56 ` [PATCH 2/7] um: virtio: use " Johannes Berg
2020-11-30 13:45 ` Anton Ivanov
2020-11-23 19:56 ` [PATCH 3/7] um: clean up alarm IRQ chip name Johannes Berg
2020-11-30 13:54 ` Anton Ivanov
2020-11-23 19:56 ` [PATCH 4/7] um: irq: clean up and rename struct irq_fd Johannes Berg
2020-11-30 14:01 ` Anton Ivanov
2020-11-23 19:56 ` [PATCH 5/7] um: irq: reduce irq_reg allocation Johannes Berg
2020-11-23 19:56 ` [PATCH 6/7] um: remove IRQ_NONE type Johannes Berg
2020-11-30 14:31 ` Anton Ivanov
2020-11-23 19:56 ` [PATCH 7/7] um: simplify IRQ handling code Johannes Berg
2020-11-24 21:50 ` Anton Ivanov
2020-11-24 21:58 ` Johannes Berg
2020-11-24 22:36 ` Anton Ivanov
2020-11-30 12:00 ` Johannes Berg
2020-11-30 13:40 ` Anton Ivanov
2020-11-30 16:30 ` Anton Ivanov
2020-12-01 20:15 ` Johannes Berg
2020-12-02 9:03 ` Anton Ivanov
2020-12-02 11:29 ` Johannes Berg [this message]
2020-12-02 11:31 ` Anton Ivanov
2020-12-02 11:32 ` Johannes Berg
2020-12-02 11:56 ` Anton Ivanov
2020-12-02 11:58 ` Johannes Berg
2020-12-02 11:43 ` Johannes Berg
2020-12-02 11:49 ` Johannes Berg
2020-12-02 11:54 ` Johannes Berg
2020-12-02 11:58 ` Anton Ivanov
2020-11-24 8:14 ` [PATCH 0/7 um: IRQ handling cleanups Anton Ivanov
2020-11-24 8:55 ` Johannes Berg
2020-11-24 8:58 ` Johannes Berg
2020-11-24 9:06 ` Anton Ivanov
2020-11-24 16:34 ` Anton Ivanov
2020-11-24 16:39 ` Johannes Berg
2020-11-24 16:42 ` Anton Ivanov
2020-11-24 16:45 ` Anton Ivanov
2020-11-24 16:46 ` Johannes Berg
2020-11-24 17:07 ` Anton Ivanov
2020-11-24 18:32 ` Johannes Berg
2020-11-24 21:11 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6cbfb799d0889dc2d34d7c773a42305d025c615b.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=anton.ivanov@kot-begemot.co.uk \
--cc=linux-um@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).