* [uml-devel] [PATCH] for ARCH=um, optionaly give a path for the vde installation.
@ 2011-05-05 7:34 paul.chavent
2011-05-06 7:52 ` richard -rw- weinberger
0 siblings, 1 reply; 6+ messages in thread
From: paul.chavent @ 2011-05-05 7:34 UTC (permalink / raw)
To: jdike; +Cc: user-mode-linux-devel
Hi.
I use uml with vde. The kernel links against libvdeplug.a and automatically find it. But i would like to manually give its path.
So i made a patch for being able to give the VDE_PREFIX when we call make.
I wonder if this patch could be included in the mainstream kernel, or if there is a better way of doing it.
Could you give me your opinion please ?
Regards .
Paul.
------------------------------------------------------------------------------
WhatsUp Gold - Download Free Network Management Software
The most intuitive, comprehensive, and cost-effective network
management toolset available today. Delivers lowest initial
acquisition cost and overall TCO of any competing solution.
http://p.sf.net/sfu/whatsupgold-sd
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [uml-devel] [PATCH] for ARCH=um, optionaly give a path for the vde installation.
2011-05-05 7:34 [uml-devel] [PATCH] for ARCH=um, optionaly give a path for the vde installation paul.chavent
@ 2011-05-06 7:52 ` richard -rw- weinberger
2011-05-06 18:10 ` Paul Chavent
0 siblings, 1 reply; 6+ messages in thread
From: richard -rw- weinberger @ 2011-05-06 7:52 UTC (permalink / raw)
To: paul.chavent; +Cc: jdike, user-mode-linux-devel
On Thu, May 5, 2011 at 9:34 AM, <paul.chavent@fnac.net> wrote:
> Hi.
>
> I use uml with vde. The kernel links against libvdeplug.a and automatically find it. But i would like to manually give its path.
>
> So i made a patch for being able to give the VDE_PREFIX when we call make.
>
> I wonder if this patch could be included in the mainstream kernel, or if there is a better way of doing it.
>
> Could you give me your opinion please ?
Please post your patch.
Otherwise nobody can review it.
--
Thanks,
//richard
------------------------------------------------------------------------------
WhatsUp Gold - Download Free Network Management Software
The most intuitive, comprehensive, and cost-effective network
management toolset available today. Delivers lowest initial
acquisition cost and overall TCO of any competing solution.
http://p.sf.net/sfu/whatsupgold-sd
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [uml-devel] [PATCH] for ARCH=um, optionaly give a path for the vde installation.
2011-05-06 7:52 ` richard -rw- weinberger
@ 2011-05-06 18:10 ` Paul Chavent
2011-05-08 22:08 ` richard -rw- weinberger
0 siblings, 1 reply; 6+ messages in thread
From: Paul Chavent @ 2011-05-06 18:10 UTC (permalink / raw)
To: richard -rw- weinberger; +Cc: jdike, user-mode-linux-devel
[-- Attachment #1: Type: text/plain, Size: 607 bytes --]
On 05/06/2011 09:52 AM, richard -rw- weinberger wrote:
>
> On Thu, May 5, 2011 at 9:34 AM,<paul.chavent@fnac.net> wrote:
>> Hi.
>>
>> I use uml with vde. The kernel links against libvdeplug.a and automatically find it. But i would like to manually give its path.
>>
>> So i made a patch for being able to give the VDE_PREFIX when we call make.
>>
>> I wonder if this patch could be included in the mainstream kernel, or if there is a better way of doing it.
>>
>> Could you give me your opinion please ?
>
> Please post your patch.
> Otherwise nobody can review it.
>
Damned
thank you for reminding me :)
[-- Attachment #2: linux-2.6.33.4-uml_vde_prefix.patch --]
[-- Type: text/plain, Size: 722 bytes --]
diff -Nur linux-2.6.26.5.orig/arch/um/drivers/Makefile linux-2.6.26.5.mod/arch/um/drivers/Makefile
--- linux-2.6.26.5.orig/arch/um/drivers/Makefile 2008-08-02 00:58:24.000000000 +0200
+++ linux-2.6.26.5.mod/arch/um/drivers/Makefile 2008-08-06 14:09:04.000000000 +0200
@@ -19,7 +19,12 @@
LDFLAGS_pcap.o := -r $(shell $(CC) $(KBUILD_CFLAGS) -print-file-name=libpcap.a)
-LDFLAGS_vde.o := -r $(shell $(CC) $(CFLAGS) -print-file-name=libvdeplug.a)
+ifdef VDE_PREFIX
+ LDFLAGS_vde.o := -r $(VDE_PREFIX)/lib/libvdeplug.a
+ CFLAGS_vde_user.o := -I$(VDE_PREFIX)/include/
+else
+ LDFLAGS_vde.o := -r $(shell $(CC) $(CFLAGS) -print-file-name=libvdeplug.a)
+endif
targets := pcap_kern.o pcap_user.o vde_kern.o vde_user.o
[-- Attachment #3: Type: text/plain, Size: 355 bytes --]
------------------------------------------------------------------------------
WhatsUp Gold - Download Free Network Management Software
The most intuitive, comprehensive, and cost-effective network
management toolset available today. Delivers lowest initial
acquisition cost and overall TCO of any competing solution.
http://p.sf.net/sfu/whatsupgold-sd
[-- Attachment #4: Type: text/plain, Size: 194 bytes --]
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [uml-devel] [PATCH] for ARCH=um, optionaly give a path for the vde installation.
2011-05-06 18:10 ` Paul Chavent
@ 2011-05-08 22:08 ` richard -rw- weinberger
2011-05-09 7:20 ` Geert Uytterhoeven
0 siblings, 1 reply; 6+ messages in thread
From: richard -rw- weinberger @ 2011-05-08 22:08 UTC (permalink / raw)
To: Paul Chavent; +Cc: jdike, user-mode-linux-devel
Hi,
On Fri, May 6, 2011 at 8:10 PM, Paul Chavent <paul.chavent@fnac.net> wrote:
> On 05/06/2011 09:52 AM, richard -rw- weinberger wrote:
>>
>> On Thu, May 5, 2011 at 9:34 AM,<paul.chavent@fnac.net> wrote:
>>>
>>> Hi.
>>>
>>> I use uml with vde. The kernel links against libvdeplug.a and
>>> automatically find it. But i would like to manually give its path.
>>>
>>> So i made a patch for being able to give the VDE_PREFIX when we call
>>> make.
>>>
>>> I wonder if this patch could be included in the mainstream kernel, or if
>>> there is a better way of doing it.
>>>
>>> Could you give me your opinion please ?
>>
>> Please post your patch.
>> Otherwise nobody can review it.
>>
> Damned
>
> thank you for reminding me :)
>
Please submit patches not as attachment.
See:
Documentation/SubmittingPatches
http://www.youtube.com/watch?v=LLBrBBImJt4
http://kapare.blogspot.com/2009/09/write-and-submit-your-first-kernel.html
Anyway, your patch makes use of "CFLAGS_vde_user.o",
where is this variable used?
--
Thanks,
//richard
------------------------------------------------------------------------------
WhatsUp Gold - Download Free Network Management Software
The most intuitive, comprehensive, and cost-effective network
management toolset available today. Delivers lowest initial
acquisition cost and overall TCO of any competing solution.
http://p.sf.net/sfu/whatsupgold-sd
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [uml-devel] [PATCH] for ARCH=um, optionaly give a path for the vde installation.
2011-05-08 22:08 ` richard -rw- weinberger
@ 2011-05-09 7:20 ` Geert Uytterhoeven
2011-05-09 7:39 ` richard -rw- weinberger
0 siblings, 1 reply; 6+ messages in thread
From: Geert Uytterhoeven @ 2011-05-09 7:20 UTC (permalink / raw)
To: richard -rw- weinberger; +Cc: Paul Chavent, jdike, user-mode-linux-devel
On Mon, May 9, 2011 at 00:08, richard -rw- weinberger
<richard.weinberger@gmail.com> wrote:
> Anyway, your patch makes use of "CFLAGS_vde_user.o",
> where is this variable used?
This syntax is used to specify additional compile options for vde_user.o.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [uml-devel] [PATCH] for ARCH=um, optionaly give a path for the vde installation.
2011-05-09 7:20 ` Geert Uytterhoeven
@ 2011-05-09 7:39 ` richard -rw- weinberger
0 siblings, 0 replies; 6+ messages in thread
From: richard -rw- weinberger @ 2011-05-09 7:39 UTC (permalink / raw)
To: Geert Uytterhoeven; +Cc: Paul Chavent, jdike, user-mode-linux-devel
On Mon, May 9, 2011 at 9:20 AM, Geert Uytterhoeven <geert@linux-m68k.org> wrote:
> On Mon, May 9, 2011 at 00:08, richard -rw- weinberger
> <richard.weinberger@gmail.com> wrote:
>> Anyway, your patch makes use of "CFLAGS_vde_user.o",
>> where is this variable used?
>
> This syntax is used to specify additional compile options for vde_user.o.
>
*headdesk*, thanks for pointing this out!
--
Thanks,
//richard
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2011-05-09 7:39 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-05-05 7:34 [uml-devel] [PATCH] for ARCH=um, optionaly give a path for the vde installation paul.chavent
2011-05-06 7:52 ` richard -rw- weinberger
2011-05-06 18:10 ` Paul Chavent
2011-05-08 22:08 ` richard -rw- weinberger
2011-05-09 7:20 ` Geert Uytterhoeven
2011-05-09 7:39 ` richard -rw- weinberger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox