From: "Tiwei Bie" <tiwei.btw@antgroup.com>
To: Johannes Berg <johannes@sipsolutions.net>,
richard@nod.at, anton.ivanov@cambridgegreys.com
Cc: linux-um@lists.infradead.org
Subject: Re: [PATCH v2 1/4] um: Add pthread-based helper support
Date: Wed, 19 Mar 2025 20:07:08 +0800 [thread overview]
Message-ID: <3df3cd48-e409-4cd6-8dae-d8062c84bf3d@antgroup.com> (raw)
In-Reply-To: <91bdd4a1200950bf26d3cbe1a42cf1beb913a153.camel@sipsolutions.net>
On 2025/3/19 17:11, Johannes Berg wrote:
> On Thu, 2025-03-06 at 23:07 +0800, Tiwei Bie wrote:
>> +void os_kill_helper_thread(struct os_helper_thread *td)
>> +{
>> + pthread_kill(td->handle, SIGKILL);
>
> This ends up killing everything.
>
[...]
>
> Anyway, the issue is I cannot shut down, I get:
>
> reboot: Power down
> Killed
>
> and the terminal isn't cleaned up, i.e. shutdown code isn't run.
Whoops, I completely missed that.. :(
Thanks a lot for the test and analysis!
It seems that SIGKILL will always take the process down [1]. We cannot
use SIGKILL to kill helper threads anymore after switching to pthread.
[1] https://web.git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/kernel/signal.c?h=v6.14-rc7#n1005
Regards,
Tiwei
next prev parent reply other threads:[~2025-03-19 12:07 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-06 15:07 [PATCH v2 0/4] um: Make errno multi-thread safe Tiwei Bie
2025-03-06 15:07 ` [PATCH v2 1/4] um: Add pthread-based helper support Tiwei Bie
2025-03-18 13:06 ` Johannes Berg
2025-03-18 13:16 ` Johannes Berg
2025-03-18 14:55 ` Tiwei Bie
2025-03-25 16:31 ` Benjamin Berg
2025-03-26 6:30 ` Tiwei Bie
2025-03-18 15:00 ` Tiwei Bie
2025-03-19 9:11 ` Johannes Berg
2025-03-19 12:07 ` Tiwei Bie [this message]
2025-03-06 15:07 ` [PATCH v2 2/4] um: ubd: Switch to the pthread-based helper Tiwei Bie
2025-03-06 15:07 ` [PATCH v2 3/4] um: Switch to the pthread-based helper in sigio workaround Tiwei Bie
2025-03-06 15:07 ` [PATCH v2 4/4] um: Prohibit the VM_CLONE flag in run_helper_thread() Tiwei Bie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3df3cd48-e409-4cd6-8dae-d8062c84bf3d@antgroup.com \
--to=tiwei.btw@antgroup.com \
--cc=anton.ivanov@cambridgegreys.com \
--cc=johannes@sipsolutions.net \
--cc=linux-um@lists.infradead.org \
--cc=richard@nod.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox