linux-um archives
 help / color / mirror / Atom feed
From: "Tiwei Bie" <tiwei.btw@antgroup.com>
To: Johannes Berg <johannes@sipsolutions.net>,
	richard@nod.at, anton.ivanov@cambridgegreys.com
Cc: linux-um@lists.infradead.org
Subject: Re: [PATCH v2 1/4] um: Add pthread-based helper support
Date: Tue, 18 Mar 2025 23:00:18 +0800	[thread overview]
Message-ID: <9c4ddb35-fb86-4d38-aa27-c6fc79f2f3a0@antgroup.com> (raw)
In-Reply-To: <306312a14326a482cba476733a4adde1799b7ccf.camel@sipsolutions.net>

On 2025/3/18 21:06, Johannes Berg wrote:
> On Thu, 2025-03-06 at 23:07 +0800, Tiwei Bie wrote:
>> Introduce a new set of utility functions that can be used to create
>> pthread-based helpers. Helper threads created in this way will ensure
>> thread safety for errno while sharing the same memory space.
> 
> Using pthreads seemed odd, but Benjamin argues that it's the only way to
> get libc to really sort it all out, unless we never use libc syscall
> functions, which is probably kind of unreasonable? Or maybe we could?

Thanks, Benjamin! :)

Yeah, it's also the only way I've figured out so far, unless we don't use libc.

> 
> 
> Either way though,
> 
>> +#include <pthread.h>
> 
>> +	err = pthread_create(&td->handle, NULL, routine, arg);
> 
> if we're going to use pthread API, then we need to link against it?

I had the same first thought, but scripts/link-vmlinux.sh already handles it:

https://web.git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/scripts/link-vmlinux.sh?h=v6.14-rc7#n85

Regards,
Tiwei


  parent reply	other threads:[~2025-03-18 15:01 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-06 15:07 [PATCH v2 0/4] um: Make errno multi-thread safe Tiwei Bie
2025-03-06 15:07 ` [PATCH v2 1/4] um: Add pthread-based helper support Tiwei Bie
2025-03-18 13:06   ` Johannes Berg
2025-03-18 13:16     ` Johannes Berg
2025-03-18 14:55       ` Tiwei Bie
2025-03-25 16:31         ` Benjamin Berg
2025-03-26  6:30           ` Tiwei Bie
2025-03-18 15:00     ` Tiwei Bie [this message]
2025-03-19  9:11   ` Johannes Berg
2025-03-19 12:07     ` Tiwei Bie
2025-03-06 15:07 ` [PATCH v2 2/4] um: ubd: Switch to the pthread-based helper Tiwei Bie
2025-03-06 15:07 ` [PATCH v2 3/4] um: Switch to the pthread-based helper in sigio workaround Tiwei Bie
2025-03-06 15:07 ` [PATCH v2 4/4] um: Prohibit the VM_CLONE flag in run_helper_thread() Tiwei Bie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9c4ddb35-fb86-4d38-aa27-c6fc79f2f3a0@antgroup.com \
    --to=tiwei.btw@antgroup.com \
    --cc=anton.ivanov@cambridgegreys.com \
    --cc=johannes@sipsolutions.net \
    --cc=linux-um@lists.infradead.org \
    --cc=richard@nod.at \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox