From: Bodo Stroesser <bstroesser@fujitsu-siemens.com>
To: BlaisorBlade <blaisorblade_spam@yahoo.it>,
Jeff Dike <jdike@addtoit.com>,
user-mode-linux-devel@lists.sourceforge.net
Subject: [uml-devel] Error in audit syscalls ?
Date: Wed, 20 Oct 2004 20:03:11 +0200 [thread overview]
Message-ID: <4176A85F.3000007@fujitsu-siemens.com> (raw)
Searching the bugs in sysemu I think I've found another little error.
Compared to i386 it should be wrong, but I don't know much about
syscall auditing. So can anyone test this?
Bodo
---
--- a/arch/um/kernel/tt/syscall_user.c 2004-10-20 19:50:06.946514414 +0200
+++ b/arch/um/kernel/tt/syscall_user.c 2004-10-20 19:50:36.562620180 +0200
@@ -29,7 +29,7 @@ void syscall_handler_tt(int sig, union u
SC_START_SYSCALL(sc);
index = record_syscall_start(syscall);
- syscall_trace(regs, 1);
+ syscall_trace(regs, 0);
result = execute_syscall(regs);
/* regs->sc may have changed while the system call ran (there may
@@ -39,7 +39,7 @@ void syscall_handler_tt(int sig, union u
SC_SET_SYSCALL_RETURN(sc, result);
- syscall_trace(regs, 0);
+ syscall_trace(regs, 1);
record_syscall_end(index, result);
}
--- a/arch/um/kernel/skas/syscall_user.c 2004-10-20 19:50:19.568428569 +0200
+++ b/arch/um/kernel/skas/syscall_user.c 2004-10-20 19:50:43.568462424 +0200
@@ -18,12 +18,12 @@ void handle_syscall(union uml_pt_regs *r
index = record_syscall_start(UPT_SYSCALL_NR(regs));
- syscall_trace(regs, 1);
+ syscall_trace(regs, 0);
result = execute_syscall(regs);
REGS_SET_SYSCALL_RETURN(regs->skas.regs, result);
- syscall_trace(regs, 0);
+ syscall_trace(regs, 1);
record_syscall_end(index, result);
}
-------------------------------------------------------
This SF.net email is sponsored by: IT Product Guide on ITManagersJournal
Use IT products in your business? Tell us what you think of them. Give us
Your Opinions, Get Free ThinkGeek Gift Certificates! Click to find out more
http://productguide.itmanagersjournal.com/guidepromo.tmpl
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel
reply other threads:[~2004-10-20 17:58 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4176A85F.3000007@fujitsu-siemens.com \
--to=bstroesser@fujitsu-siemens.com \
--cc=blaisorblade_spam@yahoo.it \
--cc=jdike@addtoit.com \
--cc=user-mode-linux-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox