[uml-devel] Error in audit syscalls ?

[uml-devel] Error in audit syscalls ?

[Bodo Stroesser]

Searching the bugs in sysemu I think I've found another little error.
Compared to i386 it should be wrong, but I don't know much about
syscall auditing. So can anyone test this?

Bodo


---

--- a/arch/um/kernel/tt/syscall_user.c	2004-10-20 19:50:06.946514414 +0200
+++ b/arch/um/kernel/tt/syscall_user.c	2004-10-20 19:50:36.562620180 +0200
@@ -29,7 +29,7 @@ void syscall_handler_tt(int sig, union u
  	SC_START_SYSCALL(sc);

  	index = record_syscall_start(syscall);
-	syscall_trace(regs, 1);
+	syscall_trace(regs, 0);
  	result = execute_syscall(regs);

  	/* regs->sc may have changed while the system call ran (there may
@@ -39,7 +39,7 @@ void syscall_handler_tt(int sig, union u

  	SC_SET_SYSCALL_RETURN(sc, result);

-	syscall_trace(regs, 0);
+	syscall_trace(regs, 1);
  	record_syscall_end(index, result);
  }

--- a/arch/um/kernel/skas/syscall_user.c	2004-10-20 19:50:19.568428569 +0200
+++ b/arch/um/kernel/skas/syscall_user.c	2004-10-20 19:50:43.568462424 +0200
@@ -18,12 +18,12 @@ void handle_syscall(union uml_pt_regs *r

  	index = record_syscall_start(UPT_SYSCALL_NR(regs));

-	syscall_trace(regs, 1);
+	syscall_trace(regs, 0);
  	result = execute_syscall(regs);

  	REGS_SET_SYSCALL_RETURN(regs->skas.regs, result);

-	syscall_trace(regs, 0);
+	syscall_trace(regs, 1);
  	record_syscall_end(index, result);
  }



-------------------------------------------------------
This SF.net email is sponsored by: IT Product Guide on ITManagersJournal
Use IT products in your business? Tell us what you think of them. Give us
Your Opinions, Get Free ThinkGeek Gift Certificates! Click to find out more
http://productguide.itmanagersjournal.com/guidepromo.tmpl
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel