[uml-devel] [patch 3/4] uml: remove most devfs_mk_symlink calls

[uml-devel] [patch 3/4] uml: remove most devfs_mk_symlink calls

[blaisorblade_spam]

Cc: Christoph Hellwig <hch@infradead.org>

Remove uses of devfs_mk_symlink().

We didn't do this before to avoid breaking most user setups, but this patch
should be quite harmless.

I've excluded the hottest part, i.e. the ubd symlink, while removing the
other; I released a end-user tree with this patch and there was a good number
of people using the symlink rather than the preferred name. That part will be
merged later, I think.

Since now we have evidence of less and less users using devfs, we think that
it will not cause too much problems.

Acked-by: Jeff Dike <jdike@addtoit.com>

Signed-off-by: Paolo 'Blaisorblade' Giarrusso <blaisorblade_spam@yahoo.it>
---

 linux-2.6.10-rc-paolo/arch/um/drivers/line.c         |    9 +--------
 linux-2.6.10-rc-paolo/arch/um/drivers/mmapper_kern.c |    1 -
 2 files changed, 1 insertion(+), 9 deletions(-)

diff -puN arch/um/drivers/line.c~uml-remove-most-devfs-mk-symlink arch/um/drivers/line.c
--- linux-2.6.10-rc/arch/um/drivers/line.c~uml-remove-most-devfs-mk-symlink	2004-11-18 18:24:27.751930176 +0100
+++ linux-2.6.10-rc-paolo/arch/um/drivers/line.c	2004-11-18 18:24:27.755929568 +0100
@@ -415,8 +415,7 @@ struct tty_driver *line_register_devfs(s
 			 struct tty_operations *ops, struct line *lines,
 			 int nlines)
 {
-	int err, i;
-	char *from, *to;
+	int i;
 	struct tty_driver *driver = alloc_tty_driver(nlines);
 
 	if (!driver)
@@ -436,12 +435,6 @@ struct tty_driver *line_register_devfs(s
 	if (tty_register_driver(driver))
 		panic("line_register_devfs : Couldn't register driver\n");
 
-	from = line_driver->symlink_from;
-	to = line_driver->symlink_to;
-	err = devfs_mk_symlink(from, to);
-	if(err) printk("Symlink creation from /dev/%s to /dev/%s "
-		       "returned %d\n", from, to, err);
-
 	for(i = 0; i < nlines; i++){
 		if(!lines[i].valid) 
 			tty_unregister_device(driver, i);
diff -puN arch/um/drivers/mmapper_kern.c~uml-remove-most-devfs-mk-symlink arch/um/drivers/mmapper_kern.c
--- linux-2.6.10-rc/arch/um/drivers/mmapper_kern.c~uml-remove-most-devfs-mk-symlink	2004-11-18 18:24:27.753929872 +0100
+++ linux-2.6.10-rc-paolo/arch/um/drivers/mmapper_kern.c	2004-11-18 18:24:27.756929416 +0100
@@ -128,7 +128,6 @@ static int __init mmapper_init(void)
 	p_buf = __pa(v_buf);
 
 	devfs_mk_cdev(MKDEV(30, 0), S_IFCHR|S_IRUGO|S_IWUGO, "mmapper");
-	devfs_mk_symlink("mmapper0", "mmapper");
 	return(0);
 }
 
_


-------------------------------------------------------
This SF.Net email is sponsored by: InterSystems CACHE
FREE OODBMS DOWNLOAD - A multidimensional database that combines
robust object and relational technologies, making it a perfect match
for Java, C++,COM, XML, ODBC and JDBC. www.intersystems.com/match8
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel

[uml-devel] Re: [patch 3/4] uml: remove most devfs_mk_symlink calls

[Nuutti Kotivuori]

blaisorblade spam wrote:
> Since now we have evidence of less and less users using devfs, we
> think that it will not cause too much problems.

Just checking - these changes do not remove support for using UML with
devfs, only removing automatic symlink creations, am I right?

We still depend on devfs working quite heavily, so I'm just making
sure.

TIA,
-- Naked




-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now. 
http://productguide.itmanagersjournal.com/
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel

Re: [uml-devel] Re: [patch 3/4] uml: remove most devfs_mk_symlink calls

[Blaisorblade]

On Monday 22 November 2004 15:43, Nuutti Kotivuori wrote:
> blaisorblade spam wrote:
> > Since now we have evidence of less and less users using devfs, we
> > think that it will not cause too much problems.

> Just checking - these changes do not remove support for using UML with
> devfs, only removing automatic symlink creations, am I right?
Yes, exactly.

> We still depend on devfs working quite heavily, so I'm just making
> sure.
I'd suggest to also stop using /dev/ubd/0 symlinks and going directly 
to /dev/ubd/disc.../disc (whatever), since the first one could soon go away 
(I've deferred that at least for now).

Bye
-- 
Paolo Giarrusso, aka Blaisorblade
Linux registered user n. 292729


-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now. 
http://productguide.itmanagersjournal.com/
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel

Re: [uml-devel] Re: [patch 3/4] uml: remove most devfs_mk_symlink calls

[Peter]

How will this affect existing UML setups?  Does it mean they would need 
to change if we started them up with a new UML kernel after /dev/ubd/0 
"goes away"?  That would mean quite a disruption to operations (i.e. 
making changes on lots of UML instances).  Is there a way to acheive 
what you're doing in a backwards-compatible manner?

Regards, Peter

Blaisorblade wrote:
> I'd suggest to also stop using /dev/ubd/0 symlinks and going directly 
> to /dev/ubd/disc.../disc (whatever), since the first one could soon go away 
> (I've deferred that at least for now).
> 
> Bye


-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now. 
http://productguide.itmanagersjournal.com/
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel

Re: [uml-devel] Re: [patch 3/4] uml: remove most devfs_mk_symlink calls

[Nuutti Kotivuori]

Blaisorblade wrote:
> I'd suggest to also stop using /dev/ubd/0 symlinks and going
> directly to /dev/ubd/disc.../disc (whatever), since the first one
> could soon go away (I've deferred that at least for now).

We run devfsd and have configured the /dev/ubd0 and /dev/ubd/0 style
symlinks there.

Thanks,
-- Naked


-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now. 
http://productguide.itmanagersjournal.com/
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel