Re: [PATCH 1/1] um: fix global timer issue when using CONFIG_NO_HZ

[Pekka Enberg <penberg@cs.helsinki.fi>]

On 16.10.2010 18.23, Richard Weinberger wrote:
> This fixes a issue which was introduced by fe2cc53e.
> timeval_to_ns() returns long long and not int.
> Due to that UML's timer did not work proper and caused timer freezes.
>
> LKML-Reference:<AANLkTik5_TCXeGzTWBZzE8F0Cb2bQq-D228xDXk87rhP () mail ! gmail ! com>
> Signed-off-by: Richard Weinberger<richard@nod.at>
> ---
>   arch/um/os-Linux/time.c |    2 +-
>   1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/um/os-Linux/time.c b/arch/um/os-Linux/time.c
> index dec5678..6e3359d 100644
> --- a/arch/um/os-Linux/time.c
> +++ b/arch/um/os-Linux/time.c
> @@ -60,7 +60,7 @@ static inline long long timeval_to_ns(const struct timeval *tv)
>   long long disable_timer(void)
>   {
>   	struct itimerval time = ((struct itimerval) { { 0, 0 }, { 0, 0 } });
> -	int remain, max = UM_NSEC_PER_SEC / UM_HZ;
> +	long long remain, max = UM_NSEC_PER_SEC / UM_HZ;
>
>   	if (setitimer(ITIMER_VIRTUAL,&time,&time)<  0)
>   		printk(UM_KERN_ERR "disable_timer - setitimer failed, "

Acked-by: Pekka Enberg <penberg@kernel.org>