* [PATCH 1/1] um: fix global timer issue when using CONFIG_NO_HZ
@ 2010-10-16 15:23 Richard Weinberger
2010-10-17 19:23 ` Pekka Enberg
0 siblings, 1 reply; 3+ messages in thread
From: Richard Weinberger @ 2010-10-16 15:23 UTC (permalink / raw)
To: akpm
Cc: linux-kernel, jdike, user-mode-linux-devel, arjan, penberg,
peterz, Richard Weinberger
This fixes a issue which was introduced by fe2cc53e.
timeval_to_ns() returns long long and not int.
Due to that UML's timer did not work proper and caused timer freezes.
LKML-Reference: <AANLkTik5_TCXeGzTWBZzE8F0Cb2bQq-D228xDXk87rhP () mail ! gmail ! com>
Signed-off-by: Richard Weinberger <richard@nod.at>
---
arch/um/os-Linux/time.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/um/os-Linux/time.c b/arch/um/os-Linux/time.c
index dec5678..6e3359d 100644
--- a/arch/um/os-Linux/time.c
+++ b/arch/um/os-Linux/time.c
@@ -60,7 +60,7 @@ static inline long long timeval_to_ns(const struct timeval *tv)
long long disable_timer(void)
{
struct itimerval time = ((struct itimerval) { { 0, 0 }, { 0, 0 } });
- int remain, max = UM_NSEC_PER_SEC / UM_HZ;
+ long long remain, max = UM_NSEC_PER_SEC / UM_HZ;
if (setitimer(ITIMER_VIRTUAL, &time, &time) < 0)
printk(UM_KERN_ERR "disable_timer - setitimer failed, "
--
1.6.6.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH 1/1] um: fix global timer issue when using CONFIG_NO_HZ
2010-10-16 15:23 [PATCH 1/1] um: fix global timer issue when using CONFIG_NO_HZ Richard Weinberger
@ 2010-10-17 19:23 ` Pekka Enberg
2010-10-18 18:58 ` Pekka Enberg
0 siblings, 1 reply; 3+ messages in thread
From: Pekka Enberg @ 2010-10-17 19:23 UTC (permalink / raw)
To: Richard Weinberger
Cc: akpm, linux-kernel, jdike, user-mode-linux-devel, arjan, peterz
On 16.10.2010 18.23, Richard Weinberger wrote:
> This fixes a issue which was introduced by fe2cc53e.
> timeval_to_ns() returns long long and not int.
> Due to that UML's timer did not work proper and caused timer freezes.
>
> LKML-Reference:<AANLkTik5_TCXeGzTWBZzE8F0Cb2bQq-D228xDXk87rhP () mail ! gmail ! com>
> Signed-off-by: Richard Weinberger<richard@nod.at>
> ---
> arch/um/os-Linux/time.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/um/os-Linux/time.c b/arch/um/os-Linux/time.c
> index dec5678..6e3359d 100644
> --- a/arch/um/os-Linux/time.c
> +++ b/arch/um/os-Linux/time.c
> @@ -60,7 +60,7 @@ static inline long long timeval_to_ns(const struct timeval *tv)
> long long disable_timer(void)
> {
> struct itimerval time = ((struct itimerval) { { 0, 0 }, { 0, 0 } });
> - int remain, max = UM_NSEC_PER_SEC / UM_HZ;
> + long long remain, max = UM_NSEC_PER_SEC / UM_HZ;
>
> if (setitimer(ITIMER_VIRTUAL,&time,&time)< 0)
> printk(UM_KERN_ERR "disable_timer - setitimer failed, "
Acked-by: Pekka Enberg <penberg@kernel.org>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH 1/1] um: fix global timer issue when using CONFIG_NO_HZ
2010-10-17 19:23 ` Pekka Enberg
@ 2010-10-18 18:58 ` Pekka Enberg
0 siblings, 0 replies; 3+ messages in thread
From: Pekka Enberg @ 2010-10-18 18:58 UTC (permalink / raw)
To: Pekka Enberg
Cc: Richard Weinberger, akpm, linux-kernel, jdike,
user-mode-linux-devel, arjan, peterz
On Sun, Oct 17, 2010 at 10:23 PM, Pekka Enberg <penberg@cs.helsinki.fi> wrote:
> On 16.10.2010 18.23, Richard Weinberger wrote:
>>
>> This fixes a issue which was introduced by fe2cc53e.
>> timeval_to_ns() returns long long and not int.
>> Due to that UML's timer did not work proper and caused timer freezes.
>>
>> LKML-Reference:<AANLkTik5_TCXeGzTWBZzE8F0Cb2bQq-D228xDXk87rhP () mail !
>> gmail ! com>
>> Signed-off-by: Richard Weinberger<richard@nod.at>
>> ---
>> �arch/um/os-Linux/time.c | � �2 +-
>> �1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/arch/um/os-Linux/time.c b/arch/um/os-Linux/time.c
>> index dec5678..6e3359d 100644
>> --- a/arch/um/os-Linux/time.c
>> +++ b/arch/um/os-Linux/time.c
>> @@ -60,7 +60,7 @@ static inline long long timeval_to_ns(const struct
>> timeval *tv)
>> �long long disable_timer(void)
>> �{
>> � � � �struct itimerval time = ((struct itimerval) { { 0, 0 }, { 0, 0 }
>> });
>> - � � � int remain, max = UM_NSEC_PER_SEC / UM_HZ;
>> + � � � long long remain, max = UM_NSEC_PER_SEC / UM_HZ;
>>
>> � � � �if (setitimer(ITIMER_VIRTUAL,&time,&time)< �0)
>> � � � � � � � �printk(UM_KERN_ERR "disable_timer - setitimer failed, "
>
> Acked-by: Pekka Enberg <penberg@kernel.org>
Andrew, do you mind picking this patch up?
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-10-18 18:58 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-10-16 15:23 [PATCH 1/1] um: fix global timer issue when using CONFIG_NO_HZ Richard Weinberger
2010-10-17 19:23 ` Pekka Enberg
2010-10-18 18:58 ` Pekka Enberg
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox