UML build broken since 3.0.75 (also affects 3.2.x)

UML build broken since 3.0.75 (also affects 3.2.x)

[Antoine Martin]

Linus' vm patches broke the UML build in 3.0.75 onwards:

  CC      mm/memory.o
mm/memory.c: In function ‘vm_iomap_memory’:
mm/memory.c:2363:2: error: implicit declaration of function
‘io_remap_pfn_range’ [-Werror=implicit-function-declaration]
cc1: some warnings being treated as errors
make[1]: *** [mm/memory.o] Error 1
make: *** [mm] Error 2


This fix is just a copy of what is found in later kernels.
Compiled and boot tested both 3.0.80 and 3.2.45, x86_64 and i386.

Signed-off-by: Antoine Martin <antoine@nagafix.co.uk>

--- a/arch/um/include/asm/pgtable.h	2013-05-25 09:20:51.420000000 +0000
+++ b/arch/um/include/asm/pgtable.h	2013-04-29 00:36:01.000000000 +0000
@@ -69,6 +69,8 @@
 #define PAGE_KERNEL	__pgprot(_PAGE_PRESENT | _PAGE_RW | _PAGE_DIRTY |
_PAGE_ACCESSED)
 #define PAGE_KERNEL_EXEC	__pgprot(__PAGE_KERNEL_EXEC)

+#define io_remap_pfn_range	remap_pfn_range
+
 /*
  * The i386 can't do page protection for execute, and considers that
the same
  * are read.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: UML build broken since 3.0.75 (also affects 3.2.x)

[Greg KH]

On Sat, May 25, 2013 at 05:55:22PM +0700, Antoine Martin wrote:
> Linus' vm patches broke the UML build in 3.0.75 onwards:
> 
>   CC      mm/memory.o
> mm/memory.c: In function ‘vm_iomap_memory’:
> mm/memory.c:2363:2: error: implicit declaration of function
> ‘io_remap_pfn_range’ [-Werror=implicit-function-declaration]
> cc1: some warnings being treated as errors
> make[1]: *** [mm/memory.o] Error 1
> make: *** [mm] Error 2
> 
> 
> This fix is just a copy of what is found in later kernels.

What is that git commit id?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: UML build broken since 3.0.75 (also affects 3.2.x)

[richard -rw- weinberger]

On Sat, May 25, 2013 at 2:18 PM, Greg KH <gregkh@linuxfoundation.org> wrote:
> On Sat, May 25, 2013 at 05:55:22PM +0700, Antoine Martin wrote:
>> Linus' vm patches broke the UML build in 3.0.75 onwards:
>>
>>   CC      mm/memory.o
>> mm/memory.c: In function ‘vm_iomap_memory’:
>> mm/memory.c:2363:2: error: implicit declaration of function
>> ‘io_remap_pfn_range’ [-Werror=implicit-function-declaration]
>> cc1: some warnings being treated as errors
>> make[1]: *** [mm/memory.o] Error 1
>> make: *** [mm] Error 2
>>
>>
>> This fix is just a copy of what is found in later kernels.
>
> What is that git commit id?

commit 4d94d6d030adfdea4837694d293ec6918d133ab2
Author: Richard Weinberger <richard@nod.at>
Date:   Tue Feb 7 01:22:47 2012 +0100

    um: Serve io_remap_pfn_range()

    At some places io_remap_pfn_range() is needed.
    UML has to serve it like all other archs do.

    Signed-off-by: Richard Weinberger <richard@nod.at>

--
Thanks,
//richard
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: UML build broken since 3.0.75 (also affects 3.2.x)

[Ben Hutchings]

[-- Attachment #1: Type: text/plain, Size: 1219 bytes --]

On Sat, 2013-05-25 at 15:44 +0200, richard -rw- weinberger wrote:
> On Sat, May 25, 2013 at 2:18 PM, Greg KH <gregkh@linuxfoundation.org> wrote:
> > On Sat, May 25, 2013 at 05:55:22PM +0700, Antoine Martin wrote:
> >> Linus' vm patches broke the UML build in 3.0.75 onwards:
> >>
> >>   CC      mm/memory.o
> >> mm/memory.c: In function ‘vm_iomap_memory’:
> >> mm/memory.c:2363:2: error: implicit declaration of function
> >> ‘io_remap_pfn_range’ [-Werror=implicit-function-declaration]
> >> cc1: some warnings being treated as errors
> >> make[1]: *** [mm/memory.o] Error 1
> >> make: *** [mm] Error 2
> >>
> >>
> >> This fix is just a copy of what is found in later kernels.
> >
> > What is that git commit id?
> 
> commit 4d94d6d030adfdea4837694d293ec6918d133ab2
> Author: Richard Weinberger <richard@nod.at>
> Date:   Tue Feb 7 01:22:47 2012 +0100
> 
>     um: Serve io_remap_pfn_range()
> 
>     At some places io_remap_pfn_range() is needed.
>     UML has to serve it like all other archs do.
> 
>     Signed-off-by: Richard Weinberger <richard@nod.at>

Queued up for 3.2, thanks all.

Ben.

-- 
Ben Hutchings
If at first you don't succeed, you're doing about average.

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 828 bytes --]