[PATCH 17/17] um: Remove unused declarations from <as-layout.h>

[PATCH 17/17] um: Remove unused declarations from <as-layout.h>

[Geert Uytterhoeven]

_end is used, but it's already provided by <asm/sections.h>, so use that.

Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Richard Weinberger <richard@nod.at>
Cc: user-mode-linux-devel@lists.sourceforge.net
---
 arch/um/include/shared/as-layout.h |    3 ---
 arch/um/kernel/um_arch.c           |    1 +
 2 files changed, 1 insertion(+), 3 deletions(-)

diff --git a/arch/um/include/shared/as-layout.h b/arch/um/include/shared/as-layout.h
index 694c792bab4e..41c8c774ec10 100644
--- a/arch/um/include/shared/as-layout.h
+++ b/arch/um/include/shared/as-layout.h
@@ -44,7 +44,6 @@ struct cpu_task {
 
 extern struct cpu_task cpu_tasks[];
 
-extern unsigned long low_physmem;
 extern unsigned long high_physmem;
 extern unsigned long uml_physmem;
 extern unsigned long uml_reserved;
@@ -52,8 +51,6 @@ extern unsigned long end_vm;
 extern unsigned long start_vm;
 extern unsigned long long highmem;
 
-extern unsigned long _stext, _etext, _sdata, _edata, __bss_start, _end;
-extern unsigned long _unprotected_end;
 extern unsigned long brk_start;
 
 extern unsigned long host_task_size;
diff --git a/arch/um/kernel/um_arch.c b/arch/um/kernel/um_arch.c
index 9fce866b0416..c44139833212 100644
--- a/arch/um/kernel/um_arch.c
+++ b/arch/um/kernel/um_arch.c
@@ -17,6 +17,7 @@
 #include <asm/byteorder.h>
 #include <asm/pgtable.h>
 #include <asm/processor.h>
+#include <asm/sections.h>
 #include <asm/setup.h>
 #include <as-layout.h>
 #include <arch.h>
-- 
1.7.9.5

Re: [PATCH 17/17] um: Remove unused declarations from <as-layout.h>

[Richard Weinberger]

Am 12.11.2013 20:42, schrieb Geert Uytterhoeven:
> _end is used, but it's already provided by <asm/sections.h>, so use that.
> 
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
> Cc: Richard Weinberger <richard@nod.at>
> Cc: user-mode-linux-devel@lists.sourceforge.net

Geert, do you want me to pickup this patch or takes Andrew the whole series?

Acked-by: Richard Weinberger <richard@nod.at>

Thanks,
//richard

> ---
>  arch/um/include/shared/as-layout.h |    3 ---
>  arch/um/kernel/um_arch.c           |    1 +
>  2 files changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/arch/um/include/shared/as-layout.h b/arch/um/include/shared/as-layout.h
> index 694c792bab4e..41c8c774ec10 100644
> --- a/arch/um/include/shared/as-layout.h
> +++ b/arch/um/include/shared/as-layout.h
> @@ -44,7 +44,6 @@ struct cpu_task {
>  
>  extern struct cpu_task cpu_tasks[];
>  
> -extern unsigned long low_physmem;
>  extern unsigned long high_physmem;
>  extern unsigned long uml_physmem;
>  extern unsigned long uml_reserved;
> @@ -52,8 +51,6 @@ extern unsigned long end_vm;
>  extern unsigned long start_vm;
>  extern unsigned long long highmem;
>  
> -extern unsigned long _stext, _etext, _sdata, _edata, __bss_start, _end;
> -extern unsigned long _unprotected_end;
>  extern unsigned long brk_start;
>  
>  extern unsigned long host_task_size;
> diff --git a/arch/um/kernel/um_arch.c b/arch/um/kernel/um_arch.c
> index 9fce866b0416..c44139833212 100644
> --- a/arch/um/kernel/um_arch.c
> +++ b/arch/um/kernel/um_arch.c
> @@ -17,6 +17,7 @@
>  #include <asm/byteorder.h>
>  #include <asm/pgtable.h>
>  #include <asm/processor.h>
> +#include <asm/sections.h>
>  #include <asm/setup.h>
>  #include <as-layout.h>
>  #include <arch.h>
> 

Re: [PATCH 17/17] um: Remove unused declarations from <as-layout.h>

[Geert Uytterhoeven]

Hi Richard,

On Tue, Nov 12, 2013 at 8:51 PM, Richard Weinberger <richard@nod.at> wrote:
> Am 12.11.2013 20:42, schrieb Geert Uytterhoeven:
>> _end is used, but it's already provided by <asm/sections.h>, so use that.
>>
>> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
>> Cc: Richard Weinberger <richard@nod.at>
>> Cc: user-mode-linux-devel@lists.sourceforge.net
>
> Geert, do you want me to pickup this patch or takes Andrew the whole series?
>
> Acked-by: Richard Weinberger <richard@nod.at>

Feel free to pick it up. Less work for (overworked?) Andrew.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds