* Re: mmotm 2013-11-20-16-13 uploaded (arch/um/kernel/sysrq.c)
[not found] <20131121001408.17DC85A41C6@corp2gmr1-2.hot.corp.google.com>
@ 2013-11-21 0:52 ` Randy Dunlap
2013-11-21 8:15 ` Richard Weinberger
0 siblings, 1 reply; 2+ messages in thread
From: Randy Dunlap @ 2013-11-21 0:52 UTC (permalink / raw)
To: akpm, mm-commits, linux-kernel, linux-mm, linux-fsdevel,
linux-next, Richard Weinberger, user-mode-linux-devel
On 11/20/13 16:14, akpm@linux-foundation.org wrote:
> The mm-of-the-moment snapshot 2013-11-20-16-13 has been uploaded to
>
> http://www.ozlabs.org/~akpm/mmotm/
>
> mmotm-readme.txt says
>
> README for mm-of-the-moment:
>
> http://www.ozlabs.org/~akpm/mmotm/
>
> This is a snapshot of my -mm patch queue. Uploaded at random hopefully
> more than once a week.
>
on i386:
(with um i386 defconfig)
arch/um/kernel/sysrq.c:22:13: error: expected identifier or '(' before 'do'
um/kernel/sysrq.c:22:13: error: expected identifier or '(' before 'while'
so sysrq.c is picking up <linux/stacktrace.h> somehow and not liking it.
--
~Randy
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: mmotm 2013-11-20-16-13 uploaded (arch/um/kernel/sysrq.c)
2013-11-21 0:52 ` mmotm 2013-11-20-16-13 uploaded (arch/um/kernel/sysrq.c) Randy Dunlap
@ 2013-11-21 8:15 ` Richard Weinberger
0 siblings, 0 replies; 2+ messages in thread
From: Richard Weinberger @ 2013-11-21 8:15 UTC (permalink / raw)
To: Randy Dunlap
Cc: akpm, mm-commits, linux-kernel, linux-mm, linux-fsdevel,
linux-next, user-mode-linux-devel
Am Mittwoch, 20. November 2013, 16:52:05 schrieb Randy Dunlap:
> On 11/20/13 16:14, akpm@linux-foundation.org wrote:
> > The mm-of-the-moment snapshot 2013-11-20-16-13 has been uploaded to
> >
> > http://www.ozlabs.org/~akpm/mmotm/
> >
> > mmotm-readme.txt says
> >
> > README for mm-of-the-moment:
> >
> > http://www.ozlabs.org/~akpm/mmotm/
> >
> > This is a snapshot of my -mm patch queue. Uploaded at random hopefully
> > more than once a week.
>
> on i386:
> (with um i386 defconfig)
>
> arch/um/kernel/sysrq.c:22:13: error: expected identifier or '(' before 'do'
> um/kernel/sysrq.c:22:13: error: expected identifier or '(' before 'while'
>
>
> so sysrq.c is picking up <linux/stacktrace.h> somehow and not liking it.
um/kernel/sysrq.c has
static void print_stack_trace(unsigned long *sp, unsigned long bp)
and linux/stracktrace.h has
# define print_stack_trace(trace, spaces) do { } while (0)
So um's print_stack_trace needs to be renamed.
Thanks a lot for reporting!
Thanks,
//richard
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-11-21 8:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20131121001408.17DC85A41C6@corp2gmr1-2.hot.corp.google.com>
2013-11-21 0:52 ` mmotm 2013-11-20-16-13 uploaded (arch/um/kernel/sysrq.c) Randy Dunlap
2013-11-21 8:15 ` Richard Weinberger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox