From: Richard Weinberger <richard@nod.at>
To: Nicolas Iooss <nicolas.iooss@polytechnique.org>,
Jeff Dike <jdike@addtoit.com>,
user-mode-linux-devel@lists.sourceforge.net,
user-mode-linux-user@lists.sourceforge.net
Cc: linux-kernel@vger.kernel.org
Subject: Re: [uml-devel] [PATCH] um: always use the same type for __syscall_stub_start
Date: Sat, 11 Oct 2014 13:42:10 +0200 [thread overview]
Message-ID: <54391792.40508@nod.at> (raw)
In-Reply-To: <1413026981-9667-1-git-send-email-nicolas.iooss_linux@m4x.org>
Am 11.10.2014 um 13:29 schrieb Nicolas Iooss:
> syscall_stub_start is declared with different types in C files:
>
> arch/um/kernel/physmem.c: extern int __syscall_stub_start;
> arch/um/kernel/skas/mmu.c: extern int __syscall_stub_start;
> arch/um/os-Linux/skas/mem.c: extern unsigned long __syscall_stub_start;
> arch/um/os-Linux/skas/process.c: extern int __syscall_stub_start;
>
> Fix this inconsistency by always using unsigned long. This does not
> change anything in the compiled code because only the address of
> __syscall_stub_start is used, but it makes the static checker I use
> stop complaining about incompatible declarations.
While we're here, can you put these declarations into a single header file?
Thanks,
//richard
------------------------------------------------------------------------------
Meet PCI DSS 3.0 Compliance Requirements with EventLog Analyzer
Achieve PCI DSS 3.0 Compliant Status with Out-of-the-box PCI DSS Reports
Are you Audit-Ready for PCI DSS 3.0 Compliance? Download White paper
Comply to PCI DSS 3.0 Requirement 10 and 11.5 with EventLog Analyzer
http://p.sf.net/sfu/Zoho
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel
next prev parent reply other threads:[~2014-10-11 11:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-11 11:29 [PATCH] um: always use the same type for __syscall_stub_start Nicolas Iooss
2014-10-11 11:42 ` Richard Weinberger [this message]
2014-10-11 12:15 ` Nicolas Iooss
2014-10-11 12:24 ` Richard Weinberger
2014-10-11 13:26 ` Nicolas Iooss
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54391792.40508@nod.at \
--to=richard@nod.at \
--cc=jdike@addtoit.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nicolas.iooss@polytechnique.org \
--cc=user-mode-linux-devel@lists.sourceforge.net \
--cc=user-mode-linux-user@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox