Re: [PATCH] um: always use the same type for __syscall_stub_start

[Nicolas Iooss <nicolas.iooss_linux@m4x.org>]

Le 11/10/2014 14:24, Richard Weinberger a écrit :
> Am 11.10.2014 um 14:15 schrieb Nicolas Iooss:
>> 2014-10-11 13:42 GMT+02:00 Richard Weinberger:
>>> Am 11.10.2014 um 13:29 schrieb Nicolas Iooss:
>>>> syscall_stub_start is declared with different types in C files:
>>>>
>>>>   arch/um/kernel/physmem.c: extern int __syscall_stub_start;
>>>>   arch/um/kernel/skas/mmu.c: extern int __syscall_stub_start;
>>>>   arch/um/os-Linux/skas/mem.c: extern unsigned long __syscall_stub_start;
>>>>   arch/um/os-Linux/skas/process.c: extern int __syscall_stub_start;
>>>>
>>>> Fix this inconsistency by always using unsigned long.  This does not
>>>> change anything in the compiled code because only the address of
>>>> __syscall_stub_start is used, but it makes the static checker I use
>>>> stop complaining about incompatible declarations.
>>>
>>> While we're here, can you put these declarations into a single header
>> file?
>>
>> Sure.  Do you have a specific header file in mind or shall I create
>> arch/um/include/asm/sections.h with declarations for
>> __syscall_stub_start, __syscall_stub_end and __binary_start (used in
>> arch/um/kernel/um_arch.c)?
> 
> Not really. Maybe you can find a common header for all.
> But I fear where is a reason why these declarations are not in a
> common header. They are used in the kernel- and userspace part of
> UML.
> Anyway, please give it a try. :)

Ok.  I'll at least try to add a kernel header and send a new patch after
some tests.

By the way, most variables in include/asm-generic/sections.h are
declared "char[]" and used without operator, contrary to
__syscall_stub_start, declared "int" or "unsigned long" and only used
with "&" operator.  Is there any reason why there are in the kernel two
ways of declaring/accessing code addresses defined in linker files?  If
not, I can send a patch which makes __syscall_stub_start "char[]"
instead of "unsigned long" to make the code a little bit clearer.

Nicolas

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/