[uml-devel] PATCH: Netdevice 0 -- port number patch

[uml-devel] PATCH: Netdevice 0 -- port number patch

[Michael Richardson]

This fixes the mcast device code to log the right port number.

--- UMLPOOL/plain/arch/um/drivers/mcast_kern.c.orig	2004-09-15 15:44:43.000000000 -0400
+++ UMLPOOL/plain/arch/um/drivers/mcast_kern.c	2004-09-15 18:45:09.000000000 -0400
@@ -43,7 +43,7 @@
 		  .dev 		= dev });
 	printk("mcast backend ");
 	printk("multicast adddress: %s:%u, TTL:%u ",
-	       dpri->addr, dpri->port, dpri->ttl);
+	       dpri->addr, ntohs(dpri->port), dpri->ttl);
 
 	printk("\n");
 }


-------------------------------------------------------
This SF.Net email is sponsored by: thawte's Crypto Challenge Vl
Crack the code and win a Sony DCRHC40 MiniDV Digital Handycam
Camcorder. More prizes in the weekly Lunch Hour Challenge.
Sign up NOW http://ad.doubleclick.net/clk;10740251;10262165;m
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel

Re: [uml-devel] PATCH: Netdevice 0 -- port number patch

[Jeff Dike]

mcr@sandelman.ottawa.on.ca said:
> This fixes the mcast device code to log the right port number.

I don't see that the port number was ever in network order, so I don't see
that it needs converting.

				Jeff



-------------------------------------------------------
This SF.Net email is sponsored by: YOU BE THE JUDGE. Be one of 170
Project Admins to receive an Apple iPod Mini FREE for your judgement on
who ports your project to Linux PPC the best. Sponsored by IBM.
Deadline: Sept. 24. Go here: http://sf.net/ppc_contest.php
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel

Re: [uml-devel] PATCH: Netdevice 0 -- port number patch

[Michael Richardson]

-----BEGIN PGP SIGNED MESSAGE-----


>>>>> "Jeff" == Jeff Dike <jdike@addtoit.com> writes:
    >> This fixes the mcast device code to log the right port number.

    Jeff> I don't see that the port number was ever in network order, so
    Jeff> I don't see that it needs converting.

  Well, it has to be in network byte order to bind() or connect() the socket.
  It is placed in network byte order at line 145 of mcast_kern.c.

  And, there is a byte order difference:

east:~# dmesg | grep eth  
Kernel command line: root=/dev/root rootfstype=hostfs rootflags=/mara4/openswan-2/nightly/UMLPOOL/east/root rw eth0=mcast,10:00:00:dc:bc:ff,239.192.0.1,21200 eth1=mcast,10:00:00:64:64:23,239.192.1.2,31200 eth2=mcast,10:00:00:32:64:23,239.192.3.2,31210

east:~# dmesg | grep 'Net'
Netdevice 0 (10:00:00:dc:bc:ff) : mcast backend multicast adddress: 239.192.0.1:53330, TTL:1 
Netdevice 1 (10:00:00:64:64:23) : mcast backend multicast adddress: 239.192.1.2:57465, TTL:1 
Netdevice 2 (10:00:00:32:64:23) : mcast backend multicast adddress: 239.192.3.2:60025, TTL:1 

and 

marajade-[/mara4/openswan-2/nightly] mcr 1039 %bc 
bc 1.06
Copyright 1991-1994, 1997, 1998, 2000 Free Software Foundation, Inc.
This is free software with ABSOLUTELY NO WARRANTY.
For details type `warranty'. 
obase=16
53330
D052
21200
52D0

- --
]     "Elmo went to the wrong fundraiser" - The Simpson         |  firewalls  [
]   Michael Richardson,    Xelerance Corporation, Ottawa, ON    |net architect[
] mcr@xelerance.com      http://www.sandelman.ottawa.on.ca/mcr/ |device driver[
] panic("Just another Debian GNU/Linux using, kernel hacking, security guy"); [
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.2 (GNU/Linux)
Comment: Finger me for keys

iQCVAwUBQUukhYqHRg3pndX9AQFzIgQA4P00Z6LG7CXmVzxh0EiRO6hJ7AwcxFfq
m2RTJP/T1kYEHLASshYNe83ujcSFU3aIKvcnbPP5w4oAM05zhLS4AXXdwQHyBLUP
3ytOci9Tt9dFN7wt9zl6QluDidi23af+lO6G/r55m/VRhRUmbunzuA+7ZuBLsu/N
8pFKzotZshQ=
=G/2j
-----END PGP SIGNATURE-----


-------------------------------------------------------
This SF.Net email is sponsored by: YOU BE THE JUDGE. Be one of 170
Project Admins to receive an Apple iPod Mini FREE for your judgement on
who ports your project to Linux PPC the best. Sponsored by IBM.
Deadline: Sept. 24. Go here: http://sf.net/ppc_contest.php
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel