From: "Steve Schmidtke" <steve_schmidtke@hotmail.com>
To: djb@cr.yp.to
Cc: User-mode-linux-devel@lists.sourceforge.net
Subject: Re: [uml-devel] [local] [kill] uml-utilities 20030903 uml_net slip_down() fails
Date: Wed, 15 Dec 2004 23:37:11 +0000 [thread overview]
Message-ID: <BAY24-F18CCBB36259F34F2AFB7C683AD0@phx.gbl> (raw)
D. J. Bernstein wrote:
>The underlying bug is that, in slip.c, slip_down() has no idea whether
>the user is actually allowed to take down the specified interface.
I'm thinking the proper fix would be to send the open fd to uml_net just
like when it was upped (if you can open it, you own it). The line
discipline on the fd can be checked with ioctl TIOCGETD if it's N_SLIP, but
I'm not sure the interface name can be recovered from the fd. The tty ioctl
TIOCSETD in the kernel looks like it returns two different values: either
the dev index if the slip line is new (useful), or 0 if it has already been
set (not useful).
Steve Schmidtke
-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://productguide.itmanagersjournal.com/
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel
reply other threads:[~2004-12-15 23:39 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BAY24-F18CCBB36259F34F2AFB7C683AD0@phx.gbl \
--to=steve_schmidtke@hotmail.com \
--cc=User-mode-linux-devel@lists.sourceforge.net \
--cc=djb@cr.yp.to \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).