Re: [uml-devel] [local] [kill] uml-utilities 20030903 uml_net slip_down() fails

Re: [uml-devel] [local] [kill] uml-utilities 20030903 uml_net slip_down() fails

[Steve Schmidtke]

D. J. Bernstein wrote:
>The underlying bug is that, in slip.c, slip_down() has no idea whether
>the user is actually allowed to take down the specified interface.

I'm thinking the proper fix would be to send the open fd to uml_net just 
like when it was upped (if you can open it, you own it).  The line 
discipline on the fd can be checked with ioctl TIOCGETD if it's N_SLIP, but 
I'm not sure the interface name can be recovered from the fd.  The tty ioctl 
TIOCSETD in the kernel looks like it returns two different values: either 
the dev index if the slip line is new (useful), or 0 if it has already been 
set (not useful).

Steve Schmidtke




-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now. 
http://productguide.itmanagersjournal.com/
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel