* [PATCH v4 3/3] asm-generic: Add new pci.h and use it [not found] <20220720131934.373932-1-shorne@gmail.com> @ 2022-07-20 13:19 ` Stafford Horne 2022-07-20 15:12 ` Arnd Bergmann ` (2 more replies) 0 siblings, 3 replies; 5+ messages in thread From: Stafford Horne @ 2022-07-20 13:19 UTC (permalink / raw) To: LKML Cc: Arnd Bergmann, Stafford Horne, Pierre Morel, Geert Uytterhoeven, Catalin Marinas, Will Deacon, Guo Ren, Paul Walmsley, Palmer Dabbelt, Albert Ou, Richard Weinberger, Anton Ivanov, Johannes Berg, Bjorn Helgaas, linux-arm-kernel, linux-csky, linux-riscv, linux-um, linux-pci, linux-arch The asm/pci.h used for many newer architectures share similar definitions. Move the common parts to asm-generic/pci.h to allow for sharing code. One thing to note: - ARCH_GENERIC_PCI_MMAP_RESOURCE, csky does not define this so we undefine it after including asm-generic/pci.h. Why doesn't csky define it? Suggested-by: Arnd Bergmann <arnd@arndb.de> Link: https://lore.kernel.org/lkml/CAK8P3a0JmPeczfmMBE__vn=Jbvf=nkbpVaZCycyv40pZNCJJXQ@mail.gmail.com/ Acked-by: Pierre Morel <pmorel@linux.ibm.com> Acked-by: Geert Uytterhoeven <geert@linux-m68k.org> Signed-off-by: Stafford Horne <shorne@gmail.com> --- Since v3: - Remove notes about pci_get_legacy_ide_irq and isa_dma_bridge_buggy. - Change ifdef around pci_proc_domain to use CONFIG_PCI_DOMAINS to avoid compile failure on User Mode linux. arch/arm64/include/asm/pci.h | 12 ++---------- arch/csky/include/asm/pci.h | 24 ++++-------------------- arch/riscv/include/asm/pci.h | 25 +++---------------------- arch/um/include/asm/pci.h | 24 ++---------------------- include/asm-generic/pci.h | 32 ++++++++++++++++++++++++++++++++ 5 files changed, 43 insertions(+), 74 deletions(-) create mode 100644 include/asm-generic/pci.h diff --git a/arch/arm64/include/asm/pci.h b/arch/arm64/include/asm/pci.h index 0aebc3488c32..016eb6b46dc0 100644 --- a/arch/arm64/include/asm/pci.h +++ b/arch/arm64/include/asm/pci.h @@ -9,7 +9,6 @@ #include <asm/io.h> #define PCIBIOS_MIN_IO 0x1000 -#define PCIBIOS_MIN_MEM 0 /* * Set to 1 if the kernel should re-assign all PCI bus numbers @@ -18,15 +17,8 @@ (pci_has_flag(PCI_REASSIGN_ALL_BUS)) #define arch_can_pci_mmap_wc() 1 -#define ARCH_GENERIC_PCI_MMAP_RESOURCE 1 -extern int isa_dma_bridge_buggy; - -#ifdef CONFIG_PCI -static inline int pci_proc_domain(struct pci_bus *bus) -{ - return 1; -} -#endif /* CONFIG_PCI */ +/* Generic PCI */ +#include <asm-generic/pci.h> #endif /* __ASM_PCI_H */ diff --git a/arch/csky/include/asm/pci.h b/arch/csky/include/asm/pci.h index ebc765b1f78b..44866c1ad461 100644 --- a/arch/csky/include/asm/pci.h +++ b/arch/csky/include/asm/pci.h @@ -9,26 +9,10 @@ #include <asm/io.h> -#define PCIBIOS_MIN_IO 0 -#define PCIBIOS_MIN_MEM 0 +/* Generic PCI */ +#include <asm-generic/pci.h> -/* C-SKY shim does not initialize PCI bus */ -#define pcibios_assign_all_busses() 1 - -extern int isa_dma_bridge_buggy; - -#ifdef CONFIG_PCI -static inline int pci_get_legacy_ide_irq(struct pci_dev *dev, int channel) -{ - /* no legacy IRQ on csky */ - return -ENODEV; -} - -static inline int pci_proc_domain(struct pci_bus *bus) -{ - /* always show the domain in /proc */ - return 1; -} -#endif /* CONFIG_PCI */ +/* csky doesn't use generic pci resource mapping */ +#undef ARCH_GENERIC_PCI_MMAP_RESOURCE #endif /* __ASM_CSKY_PCI_H */ diff --git a/arch/riscv/include/asm/pci.h b/arch/riscv/include/asm/pci.h index 7fd52a30e605..12ce8150cfb0 100644 --- a/arch/riscv/include/asm/pci.h +++ b/arch/riscv/include/asm/pci.h @@ -12,29 +12,7 @@ #include <asm/io.h> -#define PCIBIOS_MIN_IO 0 -#define PCIBIOS_MIN_MEM 0 - -/* RISC-V shim does not initialize PCI bus */ -#define pcibios_assign_all_busses() 1 - -#define ARCH_GENERIC_PCI_MMAP_RESOURCE 1 - -extern int isa_dma_bridge_buggy; - #ifdef CONFIG_PCI -static inline int pci_get_legacy_ide_irq(struct pci_dev *dev, int channel) -{ - /* no legacy IRQ on risc-v */ - return -ENODEV; -} - -static inline int pci_proc_domain(struct pci_bus *bus) -{ - /* always show the domain in /proc */ - return 1; -} - #ifdef CONFIG_NUMA static inline int pcibus_to_node(struct pci_bus *bus) @@ -50,4 +28,7 @@ static inline int pcibus_to_node(struct pci_bus *bus) #endif /* CONFIG_PCI */ +/* Generic PCI */ +#include <asm-generic/pci.h> + #endif /* _ASM_RISCV_PCI_H */ diff --git a/arch/um/include/asm/pci.h b/arch/um/include/asm/pci.h index da13fd5519ef..34fe4921b5fa 100644 --- a/arch/um/include/asm/pci.h +++ b/arch/um/include/asm/pci.h @@ -4,28 +4,8 @@ #include <linux/types.h> #include <asm/io.h> -#define PCIBIOS_MIN_IO 0 -#define PCIBIOS_MIN_MEM 0 - -#define pcibios_assign_all_busses() 1 - -extern int isa_dma_bridge_buggy; - -#ifdef CONFIG_PCI -static inline int pci_get_legacy_ide_irq(struct pci_dev *dev, int channel) -{ - /* no legacy IRQs */ - return -ENODEV; -} -#endif - -#ifdef CONFIG_PCI_DOMAINS -static inline int pci_proc_domain(struct pci_bus *bus) -{ - /* always show the domain in /proc */ - return 1; -} -#endif /* CONFIG_PCI */ +/* Generic PCI */ +#include <asm-generic/pci.h> #ifdef CONFIG_PCI_MSI_IRQ_DOMAIN /* diff --git a/include/asm-generic/pci.h b/include/asm-generic/pci.h new file mode 100644 index 000000000000..3ceb0cb12321 --- /dev/null +++ b/include/asm-generic/pci.h @@ -0,0 +1,32 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ + +#ifndef __ASM_GENERIC_PCI_H +#define __ASM_GENERIC_PCI_H + +#include <linux/types.h> + +#ifndef PCIBIOS_MIN_IO +#define PCIBIOS_MIN_IO 0 +#endif + +#ifndef PCIBIOS_MIN_MEM +#define PCIBIOS_MIN_MEM 0 +#endif + +#ifndef pcibios_assign_all_busses +/* For bootloaders that do not initialize the PCI bus */ +#define pcibios_assign_all_busses() 1 +#endif + +/* Enable generic resource mapping code in drivers/pci/ */ +#define ARCH_GENERIC_PCI_MMAP_RESOURCE + +#ifdef CONFIG_PCI_DOMAINS +static inline int pci_proc_domain(struct pci_bus *bus) +{ + /* always show the domain in /proc */ + return 1; +} +#endif /* CONFIG_PCI_DOMAINS */ + +#endif /* __ASM_GENERIC_PCI_H */ -- 2.36.1 ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH v4 3/3] asm-generic: Add new pci.h and use it 2022-07-20 13:19 ` [PATCH v4 3/3] asm-generic: Add new pci.h and use it Stafford Horne @ 2022-07-20 15:12 ` Arnd Bergmann 2022-07-20 17:43 ` Christoph Hellwig 2022-07-20 22:42 ` Bjorn Helgaas 2 siblings, 0 replies; 5+ messages in thread From: Arnd Bergmann @ 2022-07-20 15:12 UTC (permalink / raw) To: Stafford Horne Cc: LKML, Arnd Bergmann, Pierre Morel, Geert Uytterhoeven, Catalin Marinas, Will Deacon, Guo Ren, Paul Walmsley, Palmer Dabbelt, Albert Ou, Richard Weinberger, Anton Ivanov, Johannes Berg, Bjorn Helgaas, Linux ARM, linux-csky, linux-riscv, linux-um, linux-pci, linux-arch On Wed, Jul 20, 2022 at 3:19 PM Stafford Horne <shorne@gmail.com> wrote: > > The asm/pci.h used for many newer architectures share similar > definitions. Move the common parts to asm-generic/pci.h to allow for > sharing code. > > One thing to note: > > - ARCH_GENERIC_PCI_MMAP_RESOURCE, csky does not define this so we > undefine it after including asm-generic/pci.h. Why doesn't csky > define it? If you want to resolve this, I think the easiest way is to add a patch that sets this in csky, I'm quite sure this was just a mistake on their end. > Suggested-by: Arnd Bergmann <arnd@arndb.de> > Link: https://lore.kernel.org/lkml/CAK8P3a0JmPeczfmMBE__vn=Jbvf=nkbpVaZCycyv40pZNCJJXQ@mail.gmail.com/ > Acked-by: Pierre Morel <pmorel@linux.ibm.com> > Acked-by: Geert Uytterhoeven <geert@linux-m68k.org> > Signed-off-by: Stafford Horne <shorne@gmail.com> Either way: Reviewed-by: Arnd Bergmann <arnd@arndb.de> ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v4 3/3] asm-generic: Add new pci.h and use it 2022-07-20 13:19 ` [PATCH v4 3/3] asm-generic: Add new pci.h and use it Stafford Horne 2022-07-20 15:12 ` Arnd Bergmann @ 2022-07-20 17:43 ` Christoph Hellwig 2022-07-20 22:42 ` Bjorn Helgaas 2 siblings, 0 replies; 5+ messages in thread From: Christoph Hellwig @ 2022-07-20 17:43 UTC (permalink / raw) To: Stafford Horne Cc: LKML, Arnd Bergmann, Pierre Morel, Geert Uytterhoeven, Catalin Marinas, Will Deacon, Guo Ren, Paul Walmsley, Palmer Dabbelt, Albert Ou, Richard Weinberger, Anton Ivanov, Johannes Berg, Bjorn Helgaas, linux-arm-kernel, linux-csky, linux-riscv, linux-um, linux-pci, linux-arch Looks good: Reviewed-by: Christoph Hellwig <hch@lst.de> ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v4 3/3] asm-generic: Add new pci.h and use it 2022-07-20 13:19 ` [PATCH v4 3/3] asm-generic: Add new pci.h and use it Stafford Horne 2022-07-20 15:12 ` Arnd Bergmann 2022-07-20 17:43 ` Christoph Hellwig @ 2022-07-20 22:42 ` Bjorn Helgaas 2022-07-20 23:34 ` Stafford Horne 2 siblings, 1 reply; 5+ messages in thread From: Bjorn Helgaas @ 2022-07-20 22:42 UTC (permalink / raw) To: Stafford Horne Cc: LKML, Arnd Bergmann, Pierre Morel, Geert Uytterhoeven, Catalin Marinas, Will Deacon, Guo Ren, Paul Walmsley, Palmer Dabbelt, Albert Ou, Richard Weinberger, Anton Ivanov, Johannes Berg, Bjorn Helgaas, linux-arm-kernel, linux-csky, linux-riscv, linux-um, linux-pci, linux-arch On Wed, Jul 20, 2022 at 10:19:34PM +0900, Stafford Horne wrote: > The asm/pci.h used for many newer architectures share similar > definitions. Move the common parts to asm-generic/pci.h to allow for > sharing code. > > One thing to note: > > - ARCH_GENERIC_PCI_MMAP_RESOURCE, csky does not define this so we > undefine it after including asm-generic/pci.h. Why doesn't csky > define it? > > Suggested-by: Arnd Bergmann <arnd@arndb.de> > Link: https://lore.kernel.org/lkml/CAK8P3a0JmPeczfmMBE__vn=Jbvf=nkbpVaZCycyv40pZNCJJXQ@mail.gmail.com/ > Acked-by: Pierre Morel <pmorel@linux.ibm.com> > Acked-by: Geert Uytterhoeven <geert@linux-m68k.org> > Signed-off-by: Stafford Horne <shorne@gmail.com> > diff --git a/arch/arm64/include/asm/pci.h b/arch/arm64/include/asm/pci.h > index 0aebc3488c32..016eb6b46dc0 100644 > --- a/arch/arm64/include/asm/pci.h > +++ b/arch/arm64/include/asm/pci.h > -extern int isa_dma_bridge_buggy; Shouldn't this go in the previous patch? The only definition of a isa_dma_bridge_buggy variable is in drivers/pci/pci.c, and it's under #ifdef CONFIG_X86_32. Same for csky, riscv, um? ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v4 3/3] asm-generic: Add new pci.h and use it 2022-07-20 22:42 ` Bjorn Helgaas @ 2022-07-20 23:34 ` Stafford Horne 0 siblings, 0 replies; 5+ messages in thread From: Stafford Horne @ 2022-07-20 23:34 UTC (permalink / raw) To: Bjorn Helgaas Cc: LKML, Arnd Bergmann, Pierre Morel, Geert Uytterhoeven, Catalin Marinas, Will Deacon, Guo Ren, Paul Walmsley, Palmer Dabbelt, Albert Ou, Richard Weinberger, Anton Ivanov, Johannes Berg, Bjorn Helgaas, linux-arm, linux-csky, linux-riscv, linux-um, linux-pci, linux-arch [-- Attachment #1: Type: text/plain, Size: 1389 bytes --] On Thu, Jul 21, 2022, 7:42 AM Bjorn Helgaas <helgaas@kernel.org> wrote: > On Wed, Jul 20, 2022 at 10:19:34PM +0900, Stafford Horne wrote: > > The asm/pci.h used for many newer architectures share similar > > definitions. Move the common parts to asm-generic/pci.h to allow for > > sharing code. > > > > One thing to note: > > > > - ARCH_GENERIC_PCI_MMAP_RESOURCE, csky does not define this so we > > undefine it after including asm-generic/pci.h. Why doesn't csky > > define it? > > > > Suggested-by: Arnd Bergmann <arnd@arndb.de> > > Link: > https://lore.kernel.org/lkml/CAK8P3a0JmPeczfmMBE__vn=Jbvf=nkbpVaZCycyv40pZNCJJXQ@mail.gmail.com/ > > Acked-by: Pierre Morel <pmorel@linux.ibm.com> > > Acked-by: Geert Uytterhoeven <geert@linux-m68k.org> > > Signed-off-by: Stafford Horne <shorne@gmail.com> > > > diff --git a/arch/arm64/include/asm/pci.h b/arch/arm64/include/asm/pci.h > > index 0aebc3488c32..016eb6b46dc0 100644 > > --- a/arch/arm64/include/asm/pci.h > > +++ b/arch/arm64/include/asm/pci.h > > > -extern int isa_dma_bridge_buggy; > > Shouldn't this go in the previous patch? The only definition of a > isa_dma_bridge_buggy variable is in drivers/pci/pci.c, and it's under > #ifdef CONFIG_X86_32. > > Same for csky, riscv, um? > Yes, you are right. I re ordered the patches and this didn't get into the right patch. Thanks for catching this. I'll fix. - Stafford > [-- Attachment #2: Type: text/html, Size: 2572 bytes --] ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-07-20 23:34 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20220720131934.373932-1-shorne@gmail.com>
2022-07-20 13:19 ` [PATCH v4 3/3] asm-generic: Add new pci.h and use it Stafford Horne
2022-07-20 15:12 ` Arnd Bergmann
2022-07-20 17:43 ` Christoph Hellwig
2022-07-20 22:42 ` Bjorn Helgaas
2022-07-20 23:34 ` Stafford Horne
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox