From: Roberto Sassu <roberto.sassu@huaweicloud.com>
To: Johannes Berg <johannes@sipsolutions.net>,
richard@nod.at, anton.ivanov@cambridgegreys.com,
tglx@linutronix.de, mingo@redhat.com, bp@alien8.de,
dave.hansen@linux.intel.com, hpa@zytor.com
Cc: x86@kernel.org, linux-um@lists.infradead.org,
linux-kernel@vger.kernel.org, zohar@linux.ibm.com,
linux-integrity@vger.kernel.org,
Roberto Sassu <roberto.sassu@huawei.com>
Subject: Re: [PATCH] arch/x86/um: Disable UBSAN sanitization
Date: Mon, 13 May 2024 14:58:46 +0200 [thread overview]
Message-ID: <dba181a54e76ba2916ecd4747f76e40e6fbbb757.camel@huaweicloud.com> (raw)
In-Reply-To: <f88384a305b90708db3b30012f9edf09690dc5ee.camel@sipsolutions.net>
On Mon, 2024-05-13 at 14:52 +0200, Johannes Berg wrote:
> On Mon, 2024-05-13 at 14:42 +0200, Roberto Sassu wrote:
> > On Mon, 2024-05-13 at 14:29 +0200, Johannes Berg wrote:
> > > On Mon, 2024-05-13 at 14:27 +0200, Roberto Sassu wrote:
> > > > From: Roberto Sassu <roberto.sassu@huawei.com>
> > > >
> > > > Disable UBSAN sanitization on UML, since UML does not support it.
> > > >
> > >
> > > Luckily, that isn't actually true, nor does it actually do this at all.
> > > Please fix the commit message.
> >
> > Thanks, I was actually wondering. I based that statement based on
> > ARCH_HAS_UBSAN=n.
> >
> > Any other solution would be ok.
>
> Not sure I get it. What you're doing in the patch is perfectly fine and
> almost certainly required, but you're definitely not disabling UBSAN on
> ARCH=um as you described in the commit message?
Ok, I guess the right word is instrumentation (got it from commit
d4be85d068b44). And the reason is that the vDSO is executing in user
space. Will fix it.
Thanks
Roberto
next prev parent reply other threads:[~2024-05-13 12:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-13 12:27 [PATCH] arch/x86/um: Disable UBSAN sanitization Roberto Sassu
2024-05-13 12:29 ` Johannes Berg
2024-05-13 12:42 ` Roberto Sassu
2024-05-13 12:52 ` Johannes Berg
2024-05-13 12:58 ` Roberto Sassu [this message]
2024-05-13 13:08 ` Johannes Berg
2024-05-13 13:16 ` Roberto Sassu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dba181a54e76ba2916ecd4747f76e40e6fbbb757.camel@huaweicloud.com \
--to=roberto.sassu@huaweicloud.com \
--cc=anton.ivanov@cambridgegreys.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=johannes@sipsolutions.net \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-um@lists.infradead.org \
--cc=mingo@redhat.com \
--cc=richard@nod.at \
--cc=roberto.sassu@huawei.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=zohar@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox