[uml-devel] [PATCH] hostfs as root (when lauched by root)

[uml-devel] [PATCH] hostfs as root (when lauched by root)

[Hannes Schulz]

If um is launched by root hostfs works as rootfs; it just creates 
files & directories with the wrong (=root's) uid and gid. This patch 
tries to chown+chgid newly created files and directories.


Regards

Hannes

--- uml-2.4.22um5-orig/arch/um/fs/hostfs/hostfs_kern.c	2003-09-23 
15:21:33.000000000 +0200
+++ uml-2.4.22um5-hwh1/arch/um/fs/hostfs/hostfs_kern.c	2003-09-23 
19:34:40.000000000 +0200
@@ -557,7 +557,18 @@
  			 mode & S_IROTH, mode & S_IWOTH, mode & S_IXOTH);
  	if(fd < 0)
  		error = fd;
-	else error = read_name(inode, name);
+	else {
+		int ign;
+		struct hostfs_iattr uidgid;
+
+		uidgid.ia_valid = HOSTFS_ATTR_UID | HOSTFS_ATTR_GID;
+		uidgid.ia_uid = current->fsuid;
+		uidgid.ia_gid = current->fsgid;
+		/* the file was successfully created; the only reasonable
+		 * error is ENOPERM - which is ignored */
+		ign = set_attr(name, &uidgid);
+		error = read_name(inode, name);
+	}

  	kfree(name);
  	if(error){
@@ -660,6 +671,17 @@
  	file = inode_dentry_name(ino, dentry);
  	if(file == NULL) return(-ENOMEM);
  	err = do_mkdir(file, mode);
+	if(!err){
+		int ign;
+		struct hostfs_iattr uidgid;
+
+		uidgid.ia_valid = HOSTFS_ATTR_UID | HOSTFS_ATTR_GID;
+		uidgid.ia_uid = current->fsuid;
+		uidgid.ia_gid = current->fsgid;
+		/* the directory was successfully created. Errors in
+		 * set_attr are ignored */
+		ign = set_attr(file, &uidgid);
+	}
  	kfree(file);
  	return(err);
  }


-------------------------------------------------------
This sf.net email is sponsored by:ThinkGeek
Welcome to geek heaven.
http://thinkgeek.com/sf
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel

Re: [uml-devel] [PATCH] hostfs as root (when lauched by root)

[Adam Heath]

On Tue, 23 Sep 2003, Hannes Schulz wrote:

> If um is launched by root hostfs works as rootfs; it just creates
> files & directories with the wrong (=root's) uid and gid. This patch
> tries to chown+chgid newly created files and directories.

I verified that before this patch was applied, normal use in  uml would see
new files owned by root.  After applying the patch, it works as expected.



-------------------------------------------------------
This sf.net email is sponsored by:ThinkGeek
Welcome to geek heaven.
http://thinkgeek.com/sf
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel