From: Eryu Guan <eguan@redhat.com>
To: Amir Goldstein <amir73il@gmail.com>
Cc: Miklos Szeredi <miklos@szeredi.hu>,
linux-unionfs@vger.kernel.org, fstests <fstests@vger.kernel.org>
Subject: Re: [PATCH v3] overlay: test unstable inode number
Date: Mon, 12 Dec 2016 17:26:34 +0800 [thread overview]
Message-ID: <20161212092634.GX29149@eguan.usersys.redhat.com> (raw)
In-Reply-To: <CAOQ4uxhFDLr3XU7J-MGM2_L=UCHi8B99=p2C_kAj6mYUpsxstw@mail.gmail.com>
On Mon, Dec 12, 2016 at 11:21:48AM +0200, Amir Goldstein wrote:
> On Mon, Dec 12, 2016 at 11:08 AM, Eryu Guan <eguan@redhat.com> wrote:
> > On Mon, Dec 12, 2016 at 10:45:06AM +0200, Amir Goldstein wrote:
> >> Introduce a new test to demonstrate a known issue with overlayfs:
> >> - stat file A shows inode number X
> >> - modify A to trigger copy up
> >> - stat file A shows inode number Y != X
> >>
> >> Also test if d_ino of readdir entries changes after copy up.
> >>
> >> There is a POC patch by Miklos Szeredi that fixes this issue.
> >>
> >> Not dealing with hardlinks here, because there is more to test
> >> then stable inode number.
> >> Hardlinks will get a test of their own.
> >
> > Thanks! I added the missing SOB line, and added "copyup" group too.
> >
>
> Right. Thanks.
> I audited existing tests and I believe my 016 also calls for "copyup" tag
> and 013 as well.
> Do you want a patch for that or will you fix it up yourself?
Please send a new patch to fix them. Thanks!
Eryu
next prev parent reply other threads:[~2016-12-12 9:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-12 8:45 [PATCH v3] overlay: test unstable inode number Amir Goldstein
2016-12-12 9:08 ` Eryu Guan
2016-12-12 9:21 ` Amir Goldstein
2016-12-12 9:26 ` Eryu Guan [this message]
-- strict thread matches above, loose matches on Subject: below --
2016-12-13 6:18 Amir Goldstein
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161212092634.GX29149@eguan.usersys.redhat.com \
--to=eguan@redhat.com \
--cc=amir73il@gmail.com \
--cc=fstests@vger.kernel.org \
--cc=linux-unionfs@vger.kernel.org \
--cc=miklos@szeredi.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox