From: Christoph Hellwig <hch@infradead.org>
To: Amir Goldstein <amir73il@gmail.com>
Cc: Christoph Hellwig <hch@infradead.org>,
Miklos Szeredi <miklos@szeredi.hu>,
Al Viro <viro@zeniv.linux.org.uk>,
linux-unionfs@vger.kernel.org,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
Hugh Dickins <hughd@google.com>,
Andrew Morton <akpm@linux-foundation.org>,
Richard Weinberger <richard@nod.at>
Subject: Re: [PATCH] tmpfs: generate random sb->s_uuid
Date: Tue, 9 May 2017 02:02:16 -0700 [thread overview]
Message-ID: <20170509090216.GA28421@infradead.org> (raw)
In-Reply-To: <CAOQ4uxj7mtowTij45_Zh8ixhbNARxZG+YQ_UmHuoVR6AFTPHGg@mail.gmail.com>
On Fri, May 05, 2017 at 01:20:11PM +0300, Amir Goldstein wrote:
> Seriously, one has to do things in certain order.
Yes… and I want to ensure that order.
> There is no reason to wait for the common uuid code to settle down before
> fixing something as trivial as this and it makes very little sense IMO to use
> uuid_be_gen() for sb->s_uuid as it is now.
There is. generate_random_uuid needs to die, and adding more callers
isn't the way to go. Same for ubifs btw.
next prev parent reply other threads:[~2017-05-09 9:02 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-05 9:44 [PATCH] tmpfs: generate random sb->s_uuid Amir Goldstein
2017-05-05 10:01 ` Christoph Hellwig
2017-05-05 10:20 ` Amir Goldstein
2017-05-09 9:02 ` Christoph Hellwig [this message]
2017-05-09 9:18 ` Richard Weinberger
2017-05-09 9:54 ` Amir Goldstein
2017-05-09 10:09 ` Richard Weinberger
2017-05-09 10:27 ` Oleksij Rempel
2017-05-09 10:50 ` Amir Goldstein
2017-05-10 2:51 ` Hugh Dickins
2017-05-07 12:11 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170509090216.GA28421@infradead.org \
--to=hch@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=amir73il@gmail.com \
--cc=hughd@google.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-unionfs@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=richard@nod.at \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox