From: Hugh Dickins <hughd@google.com>
To: Amir Goldstein <amir73il@gmail.com>
Cc: Richard Weinberger <richard@nod.at>,
Christoph Hellwig <hch@infradead.org>,
Miklos Szeredi <miklos@szeredi.hu>,
Al Viro <viro@zeniv.linux.org.uk>,
linux-unionfs@vger.kernel.org,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
Hugh Dickins <hughd@google.com>,
Andrew Morton <akpm@linux-foundation.org>,
Oleksij Rempel <ore@pengutronix.de>
Subject: Re: [PATCH] tmpfs: generate random sb->s_uuid
Date: Tue, 9 May 2017 19:51:40 -0700 (PDT) [thread overview]
Message-ID: <alpine.LSU.2.11.1705091937590.3043@eggly.anvils> (raw)
In-Reply-To: <CAOQ4uxi5Rkz4LuU0nHQjsowLsC3jMgLG6Dmk9G8v7f78JywOSw@mail.gmail.com>
On Tue, 9 May 2017, Amir Goldstein wrote:
> On Tue, May 9, 2017 at 1:09 PM, Richard Weinberger <richard@nod.at> wrote:
>
> >
> > Well, maybe we need a new feature flag in UBIFS that the UUID is now usable.
>
> Don't think you will need that, as I wrote, none of the proposed changes have
> impact on on-disk uuid format and as Oleksij answered, for EVM/IMA checking
> uuid is an opt-in feature.
>
> >
> > My POV is easy, I'm nervous about all this changes and the rush behind them.
> > And when Christoph raises concerns, I'm especially careful.
> > That's why I'm taking the UBIFS ->s_uuid patch for 4.13 after I had enough
> > time to verify and think.
>
> Understood your POV :)
Thanks a lot for including tmpfs in your enhancements,
and mercifully I don't have to worry much about on-disk compatibility :)
but even so I share Richard's point of view: if Christoph has some
alignment in mind here, then I don't see why the rush to push something
else in right now - and the 0day robot seems to agree that it's rushed.
A welcome addition to tmpfs once fs is agreed on the way to go - thanks.
Hugh
next prev parent reply other threads:[~2017-05-10 2:51 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-05 9:44 [PATCH] tmpfs: generate random sb->s_uuid Amir Goldstein
2017-05-05 10:01 ` Christoph Hellwig
2017-05-05 10:20 ` Amir Goldstein
2017-05-09 9:02 ` Christoph Hellwig
2017-05-09 9:18 ` Richard Weinberger
2017-05-09 9:54 ` Amir Goldstein
2017-05-09 10:09 ` Richard Weinberger
2017-05-09 10:27 ` Oleksij Rempel
2017-05-09 10:50 ` Amir Goldstein
2017-05-10 2:51 ` Hugh Dickins [this message]
2017-05-07 12:11 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LSU.2.11.1705091937590.3043@eggly.anvils \
--to=hughd@google.com \
--cc=akpm@linux-foundation.org \
--cc=amir73il@gmail.com \
--cc=hch@infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-unionfs@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=ore@pengutronix.de \
--cc=richard@nod.at \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox