* [RFC PATCH miklos-vfs] ovl: ovl_fallocate() can be static
2018-04-12 15:54 [miklos-vfs:overlayfs-rorw 34/54] fs/overlayfs/file.c:271:6: sparse: symbol 'ovl_fallocate' was not declared. Should it be static? kbuild test robot
@ 2018-04-12 15:54 ` kbuild test robot
0 siblings, 0 replies; 2+ messages in thread
From: kbuild test robot @ 2018-04-12 15:54 UTC (permalink / raw)
To: Miklos Szeredi; +Cc: kbuild-all, linux-unionfs
Fixes: 9283a5d72622 ("ovl: readd fallocate")
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---
file.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/overlayfs/file.c b/fs/overlayfs/file.c
index b7b3202..fd2911b 100644
--- a/fs/overlayfs/file.c
+++ b/fs/overlayfs/file.c
@@ -268,7 +268,7 @@ static int ovl_mmap(struct file *file, struct vm_area_struct *vma)
return ret;
}
-long ovl_fallocate(struct file *file, int mode, loff_t offset, loff_t len)
+static long ovl_fallocate(struct file *file, int mode, loff_t offset, loff_t len)
{
struct inode *inode = file_inode(file);
struct fd real;
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [miklos-vfs:overlayfs-rorw 34/54] fs/overlayfs/file.c:271:6: sparse: symbol 'ovl_fallocate' was not declared. Should it be static?
@ 2018-04-12 15:54 kbuild test robot
2018-04-12 15:54 ` [RFC PATCH miklos-vfs] ovl: ovl_fallocate() can be static kbuild test robot
0 siblings, 1 reply; 2+ messages in thread
From: kbuild test robot @ 2018-04-12 15:54 UTC (permalink / raw)
To: Miklos Szeredi; +Cc: kbuild-all, linux-unionfs
tree: https://git.kernel.org/pub/scm/linux/kernel/git/mszeredi/vfs.git overlayfs-rorw
head: 9b82e69abc05b81650d3be96a50602700fc80bc4
commit: 9283a5d72622b71db31b85d96733d261eafc2dea [34/54] ovl: readd fallocate
reproduce:
# apt-get install sparse
git checkout 9283a5d72622b71db31b85d96733d261eafc2dea
make ARCH=x86_64 allmodconfig
make C=1 CF=-D__CHECK_ENDIAN__
sparse warnings: (new ones prefixed by >>)
>> fs/overlayfs/file.c:271:6: sparse: symbol 'ovl_fallocate' was not declared. Should it be static?
Please review and possibly fold the followup patch.
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-04-12 15:54 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-04-12 15:54 [miklos-vfs:overlayfs-rorw 34/54] fs/overlayfs/file.c:271:6: sparse: symbol 'ovl_fallocate' was not declared. Should it be static? kbuild test robot
2018-04-12 15:54 ` [RFC PATCH miklos-vfs] ovl: ovl_fallocate() can be static kbuild test robot
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox