Linux Overlay Filesystem development
 help / color / mirror / Atom feed
* [miklos-vfs:overlayfs-rorw 35/54] fs/overlayfs/file.c:315:6: sparse: symbol 'ovl_ioctl' was not declared. Should it be static?
@ 2018-04-12 16:13 kbuild test robot
  2018-04-12 16:13 ` [RFC PATCH miklos-vfs] ovl: ovl_ioctl() can be static kbuild test robot
  0 siblings, 1 reply; 2+ messages in thread
From: kbuild test robot @ 2018-04-12 16:13 UTC (permalink / raw)
  To: Miklos Szeredi; +Cc: kbuild-all, linux-unionfs

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/mszeredi/vfs.git overlayfs-rorw
head:   9b82e69abc05b81650d3be96a50602700fc80bc4
commit: f8395fc9f072cf62488d4b128151650bede9bc00 [35/54] ovl: readd lsattr/chattr support
reproduce:
        # apt-get install sparse
        git checkout f8395fc9f072cf62488d4b128151650bede9bc00
        make ARCH=x86_64 allmodconfig
        make C=1 CF=-D__CHECK_ENDIAN__


sparse warnings: (new ones prefixed by >>)

   fs/overlayfs/file.c:272:6: sparse: symbol 'ovl_fallocate' was not declared. Should it be static?
>> fs/overlayfs/file.c:315:6: sparse: symbol 'ovl_ioctl' was not declared. Should it be static?

Please review and possibly fold the followup patch.

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

^ permalink raw reply	[flat|nested] 2+ messages in thread

* [RFC PATCH miklos-vfs] ovl: ovl_ioctl() can be static
  2018-04-12 16:13 [miklos-vfs:overlayfs-rorw 35/54] fs/overlayfs/file.c:315:6: sparse: symbol 'ovl_ioctl' was not declared. Should it be static? kbuild test robot
@ 2018-04-12 16:13 ` kbuild test robot
  0 siblings, 0 replies; 2+ messages in thread
From: kbuild test robot @ 2018-04-12 16:13 UTC (permalink / raw)
  To: Miklos Szeredi; +Cc: kbuild-all, linux-unionfs


Fixes: f8395fc9f072 ("ovl: readd lsattr/chattr support")
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---
 file.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/overlayfs/file.c b/fs/overlayfs/file.c
index 24674cf..a8e8a1d 100644
--- a/fs/overlayfs/file.c
+++ b/fs/overlayfs/file.c
@@ -312,7 +312,7 @@ static long ovl_real_ioctl(struct file *file, unsigned int cmd,
 	return ret;
 }
 
-long ovl_ioctl(struct file *file, unsigned int cmd, unsigned long arg)
+static long ovl_ioctl(struct file *file, unsigned int cmd, unsigned long arg)
 {
 	long ret;
 	struct inode *inode = file_inode(file);

^ permalink raw reply related	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2018-04-12 16:13 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-04-12 16:13 [miklos-vfs:overlayfs-rorw 35/54] fs/overlayfs/file.c:315:6: sparse: symbol 'ovl_ioctl' was not declared. Should it be static? kbuild test robot
2018-04-12 16:13 ` [RFC PATCH miklos-vfs] ovl: ovl_ioctl() can be static kbuild test robot

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox