From: Christian Brauner <brauner@kernel.org>
To: Amir Goldstein <amir73il@gmail.com>
Cc: Miklos Szeredi <miklos@szeredi.hu>, linux-unionfs@vger.kernel.org
Subject: Re: [PATCH v2 0/5] Prep patches for porting overlayfs to new mount api
Date: Tue, 20 Jun 2023 12:12:02 +0200 [thread overview]
Message-ID: <20230620-euren-betiteln-cc3335d5579c@brauner> (raw)
In-Reply-To: <CAOQ4uxjLm92xRoSoexheyAE49298++hAWs4MbqyT8KEAZJQtdQ@mail.gmail.com>
On Tue, Jun 20, 2023 at 12:46:52PM +0300, Amir Goldstein wrote:
> On Tue, Jun 20, 2023 at 12:26 PM Christian Brauner <brauner@kernel.org> wrote:
> >
> > On Sat, Jun 17, 2023 at 11:46:57AM +0300, Amir Goldstein wrote:
> > > Miklos,
> > >
> > > Following some more cleanup patches that make Christian's new mount api
> > > patches smaller and easier to review.
> > >
> > > I had rebased Christain's patches over these cleanups and pushed the
> > > result to github branch fs-overlayfs-mount_api [1].
> > >
> > > The v1 prep patches had a bug with xino option parsing that resulted in
> > > some tests being skipped (not failing) and I had only noticed the
> > > skipped test after posting v1.
> > >
> > > The v2 prep patches + new mount api patches have passed all the tests
> > > with no new tests skipped.
> > >
> > > In addition to running the tests with the default kernel config, I also
> > > ran the tests with the following non-default configs (individually):
> > >
> > > 1) CONFIG_OVERLAY_FS_REDIRECT_DIR=y
> > > 2) CONFIG_OVERLAY_FS_REDIRECT_ALWAYS_FOLLOW=n
> > > 3) CONFIG_OVERLAY_FS_XINO_AUTO=y
> >
> > Thanks for splitting some work into preparatory patches. I'm not sure
> > how worthwhile this actually is given they aren't marked as backports
> > for LTS releases so the overall delta ould still the same between LTSes
> > and mainline but it might make bisection easier.
>
> Yeh, bisection, review, all the usual reasons for keep unrelated changes
> split. I am not usually fanatic about splitting hairs on this, but the
> mount api porting patch was already a big change that was hard for me to
> review and it grew all those extra additions like redirect_mode which
> were good changes, but not related, so I did this to make my own (and others)
> review of your patches easier.
>
> I am glad if we are all happy with the end result.
Yeah, I appreciate the work and wasn't trying to critique it. I just
wouldn't have bothered because the mount api port in itself is
cumbersome enough. :)
prev parent reply other threads:[~2023-06-20 10:12 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-17 8:46 [PATCH v2 0/5] Prep patches for porting overlayfs to new mount api Amir Goldstein
2023-06-17 8:46 ` [PATCH v2 1/5] ovl: negate the ofs->share_whiteout boolean Amir Goldstein
2023-06-20 9:20 ` Christian Brauner
2023-06-17 8:46 ` [PATCH v2 2/5] ovl: clarify ovl_get_root() semantics Amir Goldstein
2023-06-20 9:21 ` Christian Brauner
2023-06-17 8:47 ` [PATCH v2 3/5] ovl: pass ovl_fs to xino helpers Amir Goldstein
2023-06-20 9:21 ` Christian Brauner
2023-06-17 8:47 ` [PATCH v2 4/5] ovl: store enum redirect_mode in config instead of a string Amir Goldstein
2023-06-20 8:48 ` Miklos Szeredi
2023-06-20 8:50 ` Miklos Szeredi
2023-06-20 9:23 ` Christian Brauner
2023-06-17 8:47 ` [PATCH v2 5/5] ovl: factor out ovl_parse_options() helper Amir Goldstein
2023-06-20 9:19 ` Christian Brauner
2023-06-20 9:26 ` [PATCH v2 0/5] Prep patches for porting overlayfs to new mount api Christian Brauner
2023-06-20 9:46 ` Amir Goldstein
2023-06-20 10:12 ` Christian Brauner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230620-euren-betiteln-cc3335d5579c@brauner \
--to=brauner@kernel.org \
--cc=amir73il@gmail.com \
--cc=linux-unionfs@vger.kernel.org \
--cc=miklos@szeredi.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox