Linux Overlay Filesystem development
 help / color / mirror / Atom feed
From: Miklos Szeredi <miklos@szeredi.hu>
To: Amir Goldstein <amir73il@gmail.com>
Cc: Christian Brauner <brauner@kernel.org>, linux-unionfs@vger.kernel.org
Subject: Re: [PATCH v2 4/5] ovl: store enum redirect_mode in config instead of a string
Date: Tue, 20 Jun 2023 10:48:09 +0200	[thread overview]
Message-ID: <CAJfpegsM44b8rRhGSgUMEroyuwp_Xd16NJeT699VMAKjFfG5JA@mail.gmail.com> (raw)
In-Reply-To: <20230617084702.2468470-5-amir73il@gmail.com>

On Sat, 17 Jun 2023 at 10:47, Amir Goldstein <amir73il@gmail.com> wrote:

> @@ -1332,10 +1337,17 @@ static int ovl_make_workdir(struct super_block *sb, struct ovl_fs *ofs,
>         if (err) {
>                 pr_warn("failed to set xattr on upper\n");
>                 ofs->noxattr = true;
> -               if (ofs->config.index || ofs->config.metacopy) {
> -                       ofs->config.index = false;
> +               if (ovl_redirect_follow(ofs)) {
> +                       ofs->config.redirect_mode = OVL_REDIRECT_NOFOLLOW;
> +                       pr_warn("...falling back to redirect_dir=nofollow.\n");


So if there's no xattr support, then there won't be any redirects to
follow.   Is this just asserting the fact?

Should this be a separate patch?

Thanks,
Miklos

  reply	other threads:[~2023-06-20  8:48 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-17  8:46 [PATCH v2 0/5] Prep patches for porting overlayfs to new mount api Amir Goldstein
2023-06-17  8:46 ` [PATCH v2 1/5] ovl: negate the ofs->share_whiteout boolean Amir Goldstein
2023-06-20  9:20   ` Christian Brauner
2023-06-17  8:46 ` [PATCH v2 2/5] ovl: clarify ovl_get_root() semantics Amir Goldstein
2023-06-20  9:21   ` Christian Brauner
2023-06-17  8:47 ` [PATCH v2 3/5] ovl: pass ovl_fs to xino helpers Amir Goldstein
2023-06-20  9:21   ` Christian Brauner
2023-06-17  8:47 ` [PATCH v2 4/5] ovl: store enum redirect_mode in config instead of a string Amir Goldstein
2023-06-20  8:48   ` Miklos Szeredi [this message]
2023-06-20  8:50     ` Miklos Szeredi
2023-06-20  9:23   ` Christian Brauner
2023-06-17  8:47 ` [PATCH v2 5/5] ovl: factor out ovl_parse_options() helper Amir Goldstein
2023-06-20  9:19   ` Christian Brauner
2023-06-20  9:26 ` [PATCH v2 0/5] Prep patches for porting overlayfs to new mount api Christian Brauner
2023-06-20  9:46   ` Amir Goldstein
2023-06-20 10:12     ` Christian Brauner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAJfpegsM44b8rRhGSgUMEroyuwp_Xd16NJeT699VMAKjFfG5JA@mail.gmail.com \
    --to=miklos@szeredi.hu \
    --cc=amir73il@gmail.com \
    --cc=brauner@kernel.org \
    --cc=linux-unionfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox