* [PATCH 27/29] overlayfs: move xattr tables to .rodata
[not found] <20230930050033.41174-1-wedsonaf@gmail.com>
@ 2023-09-30 5:00 ` Wedson Almeida Filho
2023-10-03 16:41 ` Amir Goldstein
0 siblings, 1 reply; 2+ messages in thread
From: Wedson Almeida Filho @ 2023-09-30 5:00 UTC (permalink / raw)
To: Alexander Viro, Christian Brauner, linux-fsdevel
Cc: linux-kernel, Wedson Almeida Filho, Miklos Szeredi,
Amir Goldstein, linux-unionfs
From: Wedson Almeida Filho <walmeida@microsoft.com>
This makes it harder for accidental or malicious changes to
ovl_trusted_xattr_handlers or ovl_user_xattr_handlers at runtime.
Cc: Miklos Szeredi <miklos@szeredi.hu>
Cc: Amir Goldstein <amir73il@gmail.com>
Cc: linux-unionfs@vger.kernel.org
Signed-off-by: Wedson Almeida Filho <walmeida@microsoft.com>
---
fs/overlayfs/super.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/fs/overlayfs/super.c b/fs/overlayfs/super.c
index cc8977498c48..fe7af47be621 100644
--- a/fs/overlayfs/super.c
+++ b/fs/overlayfs/super.c
@@ -477,13 +477,13 @@ static const struct xattr_handler ovl_other_xattr_handler = {
.set = ovl_other_xattr_set,
};
-static const struct xattr_handler *ovl_trusted_xattr_handlers[] = {
+static const struct xattr_handler * const ovl_trusted_xattr_handlers[] = {
&ovl_own_trusted_xattr_handler,
&ovl_other_xattr_handler,
NULL
};
-static const struct xattr_handler *ovl_user_xattr_handlers[] = {
+static const struct xattr_handler * const ovl_user_xattr_handlers[] = {
&ovl_own_user_xattr_handler,
&ovl_other_xattr_handler,
NULL
--
2.34.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 27/29] overlayfs: move xattr tables to .rodata
2023-09-30 5:00 ` [PATCH 27/29] overlayfs: move xattr tables to .rodata Wedson Almeida Filho
@ 2023-10-03 16:41 ` Amir Goldstein
0 siblings, 0 replies; 2+ messages in thread
From: Amir Goldstein @ 2023-10-03 16:41 UTC (permalink / raw)
To: Wedson Almeida Filho
Cc: Alexander Viro, Christian Brauner, linux-fsdevel, linux-kernel,
Wedson Almeida Filho, Miklos Szeredi, linux-unionfs
On Sat, Sep 30, 2023 at 8:02 AM Wedson Almeida Filho <wedsonaf@gmail.com> wrote:
>
> From: Wedson Almeida Filho <walmeida@microsoft.com>
>
> This makes it harder for accidental or malicious changes to
> ovl_trusted_xattr_handlers or ovl_user_xattr_handlers at runtime.
>
> Cc: Miklos Szeredi <miklos@szeredi.hu>
> Cc: Amir Goldstein <amir73il@gmail.com>
> Cc: linux-unionfs@vger.kernel.org
> Signed-off-by: Wedson Almeida Filho <walmeida@microsoft.com>
Acked-by: Amir Goldstein <amir73il@gmail.com>
> ---
> fs/overlayfs/super.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/fs/overlayfs/super.c b/fs/overlayfs/super.c
> index cc8977498c48..fe7af47be621 100644
> --- a/fs/overlayfs/super.c
> +++ b/fs/overlayfs/super.c
> @@ -477,13 +477,13 @@ static const struct xattr_handler ovl_other_xattr_handler = {
> .set = ovl_other_xattr_set,
> };
>
> -static const struct xattr_handler *ovl_trusted_xattr_handlers[] = {
> +static const struct xattr_handler * const ovl_trusted_xattr_handlers[] = {
> &ovl_own_trusted_xattr_handler,
> &ovl_other_xattr_handler,
> NULL
> };
>
> -static const struct xattr_handler *ovl_user_xattr_handlers[] = {
> +static const struct xattr_handler * const ovl_user_xattr_handlers[] = {
> &ovl_own_user_xattr_handler,
> &ovl_other_xattr_handler,
> NULL
> --
> 2.34.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-10-03 16:41 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20230930050033.41174-1-wedsonaf@gmail.com>
2023-09-30 5:00 ` [PATCH 27/29] overlayfs: move xattr tables to .rodata Wedson Almeida Filho
2023-10-03 16:41 ` Amir Goldstein
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox