From: James Morris <jmorris@namei.org>
To: Mark Salyzyn <salyzyn@android.com>
Cc: Latchesar Ionkov <lucho@ionkov.net>,
Dave Kleikamp <shaggy@kernel.org>,
jfs-discussion@lists.sourceforge.net, kernel-team@android.com,
linux-integrity@vger.kernel.org,
Martin Brandenburg <martin@omnibond.com>,
samba-technical@lists.samba.org,
Dominique Martinet <asmadeus@codewreck.org>,
Chao Yu <yuchao0@huawei.com>, Mimi Zohar <zohar@linux.ibm.com>,
linux-unionfs@vger.kernel.org,
David Howells <dhowells@redhat.com>, Chris Mason <clm@fb.com>,
"David S. Miller" <davem@davemloft.net>,
Andreas Dilger <adilger.kernel@dilger.ca>,
Eric Paris <eparis@parisplace.org>,
netdev@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net,
linux-afs@lists.infradead.org,
Mike Marshall <hubcap@omnibond.com>,
linux-xfs@vger.kernel.org,
Andreas Gruenbacher <agruenba@redhat.com>,
Sage Weil <sage@redhat.com>, Miklos Szeredi <miklos@szeredi.hu>,
Richard Weinberger <richard@nod.at>Mark Fasheh <m>
Subject: Re: [PATCH] Add flags option to get xattr method paired to __vfs_getxattr
Date: Fri, 16 Aug 2019 08:27:07 +1000 (AEST) [thread overview]
Message-ID: <alpine.LRH.2.21.1908160825310.22623@namei.org> (raw)
In-Reply-To: <69889dec-5440-1472-ed57-380f45547581@android.com>
On Thu, 15 Aug 2019, Mark Salyzyn wrote:
> Good Idea, but using the same argument structure for set and get I would be
> concerned about the loss of compiler protection for the buffer argument;
Agreed, I missed that.
> struct getxattr_args {
> struct dentry *dentry;
> struct inode *inode;
> const char *name;
> void *buffer;
> size_t size;
> int flags;
Does 'get' need flags?
--
James Morris
<jmorris@namei.org>
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2019-08-15 22:27 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-12 19:32 [PATCH] Add flags option to get xattr method paired to __vfs_getxattr Mark Salyzyn via Linux-f2fs-devel
2019-08-13 8:28 ` kbuild test robot
2019-08-13 8:48 ` Greg Kroah-Hartman
2019-08-13 14:37 ` Mark Salyzyn via Linux-f2fs-devel
2019-08-15 19:20 ` James Morris
2019-08-15 20:43 ` Greg Kroah-Hartman
2019-08-15 21:26 ` Mark Salyzyn
2019-08-15 22:27 ` James Morris [this message]
2019-08-16 15:30 ` Mark Salyzyn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LRH.2.21.1908160825310.22623@namei.org \
--to=jmorris@namei.org \
--cc=adilger.kernel@dilger.ca \
--cc=agruenba@redhat.com \
--cc=asmadeus@codewreck.org \
--cc=clm@fb.com \
--cc=davem@davemloft.net \
--cc=dhowells@redhat.com \
--cc=eparis@parisplace.org \
--cc=hubcap@omnibond.com \
--cc=jfs-discussion@lists.sourceforge.net \
--cc=kernel-team@android.com \
--cc=linux-afs@lists.infradead.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-unionfs@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=lucho@ionkov.net \
--cc=martin@omnibond.com \
--cc=miklos@szeredi.hu \
--cc=netdev@vger.kernel.org \
--cc=richard@nod.at \
--cc=sage@redhat.com \
--cc=salyzyn@android.com \
--cc=samba-technical@lists.samba.org \
--cc=shaggy@kernel.org \
--cc=yuchao0@huawei.com \
--cc=zohar@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox