Linux USB
 help / color / mirror / Atom feed
From: Romain Gantois <romain.gantois@bootlin.com>
To: Heikki Krogerus <heikki.krogerus@linux.intel.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Pengpeng Hou <pengpeng@iscas.ac.cn>
Cc: Pengpeng Hou <pengpeng@iscas.ac.cn>,
	linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] usb: typec: mux: tusb1046: add missing MODULE_DEVICE_TABLE()
Date: Tue, 07 Jul 2026 10:47:09 +0200	[thread overview]
Message-ID: <-fYRkNfmRlGE9g_eYnGyjA@bootlin.com> (raw)
In-Reply-To: <20260704124714.18404-1-pengpeng@iscas.ac.cn>

[-- Attachment #1: Type: text/plain, Size: 1217 bytes --]

Hi Pengpeng,

On Saturday, 4 July 2026 14:47:14 CEST Pengpeng Hou wrote:
> The driver has an OF match table wired to .of_match_table, but does
> not export the table with MODULE_DEVICE_TABLE().
> 
> Add the missing MODULE_DEVICE_TABLE(of, ...) entry so module alias
> information is generated for OF based module autoloading.
> 
> This is a source-level fix.  It does not claim dynamic hardware
> reproduction; the evidence is the driver-owned match table, its use by
> the platform driver, and the missing module alias publication.
> 
> Signed-off-by: Pengpeng Hou <pengpeng@iscas.ac.cn>
> ---
> 
>  drivers/usb/typec/mux/tusb1046.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/usb/typec/mux/tusb1046.c
> b/drivers/usb/typec/mux/tusb1046.c index d6e1289a4945..34ef81f75693 100644
> --- a/drivers/usb/typec/mux/tusb1046.c
> +++ b/drivers/usb/typec/mux/tusb1046.c
> @@ -178,6 +178,7 @@ static const struct of_device_id tusb1046_match_table[]
> = { {.compatible = "ti,tusb1046"},
> 
>  	{},
>  
>  };
> 
> +MODULE_DEVICE_TABLE(of, tusb1046_match_table);
> 
>  static struct i2c_driver tusb1046_driver = {
>  
>  	.driver = {

LGTM, thanks!

Reviewed-by: Romain Gantois <romain.gantois@bootlin.com>

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

      reply	other threads:[~2026-07-07  8:47 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-04 12:47 [PATCH] usb: typec: mux: tusb1046: add missing MODULE_DEVICE_TABLE() Pengpeng Hou
2026-07-07  8:47 ` Romain Gantois [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=-fYRkNfmRlGE9g_eYnGyjA@bootlin.com \
    --to=romain.gantois@bootlin.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=heikki.krogerus@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=pengpeng@iscas.ac.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox