* [PATCH] usb: typec: mux: tusb1046: add missing MODULE_DEVICE_TABLE()
@ 2026-07-04 12:47 Pengpeng Hou
2026-07-07 8:47 ` Romain Gantois
0 siblings, 1 reply; 2+ messages in thread
From: Pengpeng Hou @ 2026-07-04 12:47 UTC (permalink / raw)
To: Romain Gantois, Heikki Krogerus, Greg Kroah-Hartman
Cc: Pengpeng Hou, linux-usb, linux-kernel
The driver has an OF match table wired to .of_match_table, but does
not export the table with MODULE_DEVICE_TABLE().
Add the missing MODULE_DEVICE_TABLE(of, ...) entry so module alias
information is generated for OF based module autoloading.
This is a source-level fix. It does not claim dynamic hardware
reproduction; the evidence is the driver-owned match table, its use by
the platform driver, and the missing module alias publication.
Signed-off-by: Pengpeng Hou <pengpeng@iscas.ac.cn>
---
drivers/usb/typec/mux/tusb1046.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/usb/typec/mux/tusb1046.c b/drivers/usb/typec/mux/tusb1046.c
index d6e1289a4945..34ef81f75693 100644
--- a/drivers/usb/typec/mux/tusb1046.c
+++ b/drivers/usb/typec/mux/tusb1046.c
@@ -178,6 +178,7 @@ static const struct of_device_id tusb1046_match_table[] = {
{.compatible = "ti,tusb1046"},
{},
};
+MODULE_DEVICE_TABLE(of, tusb1046_match_table);
static struct i2c_driver tusb1046_driver = {
.driver = {
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] usb: typec: mux: tusb1046: add missing MODULE_DEVICE_TABLE()
2026-07-04 12:47 [PATCH] usb: typec: mux: tusb1046: add missing MODULE_DEVICE_TABLE() Pengpeng Hou
@ 2026-07-07 8:47 ` Romain Gantois
0 siblings, 0 replies; 2+ messages in thread
From: Romain Gantois @ 2026-07-07 8:47 UTC (permalink / raw)
To: Heikki Krogerus, Greg Kroah-Hartman, Pengpeng Hou
Cc: Pengpeng Hou, linux-usb, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1217 bytes --]
Hi Pengpeng,
On Saturday, 4 July 2026 14:47:14 CEST Pengpeng Hou wrote:
> The driver has an OF match table wired to .of_match_table, but does
> not export the table with MODULE_DEVICE_TABLE().
>
> Add the missing MODULE_DEVICE_TABLE(of, ...) entry so module alias
> information is generated for OF based module autoloading.
>
> This is a source-level fix. It does not claim dynamic hardware
> reproduction; the evidence is the driver-owned match table, its use by
> the platform driver, and the missing module alias publication.
>
> Signed-off-by: Pengpeng Hou <pengpeng@iscas.ac.cn>
> ---
>
> drivers/usb/typec/mux/tusb1046.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/usb/typec/mux/tusb1046.c
> b/drivers/usb/typec/mux/tusb1046.c index d6e1289a4945..34ef81f75693 100644
> --- a/drivers/usb/typec/mux/tusb1046.c
> +++ b/drivers/usb/typec/mux/tusb1046.c
> @@ -178,6 +178,7 @@ static const struct of_device_id tusb1046_match_table[]
> = { {.compatible = "ti,tusb1046"},
>
> {},
>
> };
>
> +MODULE_DEVICE_TABLE(of, tusb1046_match_table);
>
> static struct i2c_driver tusb1046_driver = {
>
> .driver = {
LGTM, thanks!
Reviewed-by: Romain Gantois <romain.gantois@bootlin.com>
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-07-07 8:47 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-07-04 12:47 [PATCH] usb: typec: mux: tusb1046: add missing MODULE_DEVICE_TABLE() Pengpeng Hou
2026-07-07 8:47 ` Romain Gantois
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox