Linux USB
 help / color / mirror / Atom feed
* [PATCH] usb: bdc: Use devm_clk_get_optional_enabled() in bdc_probe()
@ 2026-11-19 19:06 Markus Elfring
  2026-11-19 19:12 ` sashiko-bot
  0 siblings, 1 reply; 2+ messages in thread
From: Markus Elfring @ 2026-11-19 19:06 UTC (permalink / raw)
  To: linux-usb, bcm-kernel-feedback-list, Al Cooper,
	Greg Kroah-Hartman, Justin Chen, Neill Kapron
  Cc: LKML, kernel-janitors

From: Markus Elfring <elfring@users.sourceforge.net>
Date: Thu, 19 Nov 2026 20:00:07 +0100

Reuse existing functionality from devm_clk_get_optional_enabled()
instead of keeping duplicate source code.

The source code was transformed by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
 drivers/usb/gadget/udc/bdc/bdc_core.c | 8 +-------
 1 file changed, 1 insertion(+), 7 deletions(-)

diff --git a/drivers/usb/gadget/udc/bdc/bdc_core.c b/drivers/usb/gadget/udc/bdc/bdc_core.c
index 5149c98bf9bf..ce09327250f4 100644
--- a/drivers/usb/gadget/udc/bdc/bdc_core.c
+++ b/drivers/usb/gadget/udc/bdc/bdc_core.c
@@ -530,16 +530,10 @@ static int bdc_probe(struct platform_device *pdev)
 		}
 	}
 
-	bdc->clk = devm_clk_get_optional(dev, "sw_usbd");
+	bdc->clk = devm_clk_get_optional_enabled(dev, "sw_usbd");
 	if (IS_ERR(bdc->clk))
 		return PTR_ERR(bdc->clk);
 
-	ret = clk_prepare_enable(bdc->clk);
-	if (ret) {
-		dev_err(dev, "could not enable clock\n");
-		return ret;
-	}
-
 	ret = bdc_phy_init(bdc);
 	if (ret) {
 		dev_err(bdc->dev, "BDC phy init failure:%d\n", ret);
-- 
2.56.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] usb: bdc: Use devm_clk_get_optional_enabled() in bdc_probe()
  2026-11-19 19:06 [PATCH] usb: bdc: Use devm_clk_get_optional_enabled() in bdc_probe() Markus Elfring
@ 2026-11-19 19:12 ` sashiko-bot
  0 siblings, 0 replies; 2+ messages in thread
From: sashiko-bot @ 2026-11-19 19:12 UTC (permalink / raw)
  To: Markus Elfring, linux-usb

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [High] usb: bdc: double clk_disable_unprepare() in bdc_probe() and
  bdc_remove()
--

commit c38d4d54fe3bb2b28c05aba44e9d088e2b2d7d63
Author: Markus Elfring <elfring@users.sourceforge.net>

usb: bdc: Use devm_clk_get_optional_enabled() in bdc_probe()

This commit replaces devm_clk_get_optional() and clk_prepare_enable() in
bdc_probe() with devm_clk_get_optional_enabled().

> diff --git a/drivers/usb/gadget/udc/bdc/bdc_core.c b/drivers/usb/gadget/udc/bdc/bdc_core.c
> index 5149c98bf9bf9..ce09327250f43 100644
> --- a/drivers/usb/gadget/udc/bdc/bdc_core.c
> +++ b/drivers/usb/gadget/udc/bdc/bdc_core.c
> @@ -530,16 +530,10 @@ static int bdc_probe(struct platform_device *pdev)
>  		}
>  	}
>  
> -	bdc->clk = devm_clk_get_optional(dev, "sw_usbd");
> +	bdc->clk = devm_clk_get_optional_enabled(dev, "sw_usbd");
>  	if (IS_ERR(bdc->clk))
>  		return PTR_ERR(bdc->clk);
>  
> -	ret = clk_prepare_enable(bdc->clk);
> -	if (ret) {
> -		dev_err(dev, "could not enable clock\n");
> -		return ret;
> -	}
> -
>  	ret = bdc_phy_init(bdc);
>  	if (ret) {
>  		dev_err(bdc->dev, "BDC phy init failure:%d\n", ret);

[Severity: High]
Does this cause clk_disable_unprepare(bdc->clk) to be called twice on probe
failure or driver removal?

devm_clk_get_optional_enabled() registers a devres action that calls
clk_disable_unprepare(bdc->clk) on probe failure or device unbind, but the
manual clk_disable_unprepare(bdc->clk) calls remain in the disable_clk
error path of bdc_probe() and in bdc_remove().  That underflows the clock
enable and prepare counts, triggering WARN_ON() in clk_core_disable() and
clk_core_unprepare().

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/07112f96-430c-4109-9aca-e5d17e333d67@web.de?part=1

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2026-11-19 19:12 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-11-19 19:06 [PATCH] usb: bdc: Use devm_clk_get_optional_enabled() in bdc_probe() Markus Elfring
2026-11-19 19:12 ` sashiko-bot

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox