From: Mathias Nyman <mathias.nyman@linux.intel.com>
To: Rafael Mendonca <rafaelmendsr@gmail.com>,
Mathias Nyman <mathias.nyman@intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] xhci: dbc: Fix memory leak in xhci_alloc_dbc()
Date: Wed, 14 Sep 2022 15:27:07 +0300 [thread overview]
Message-ID: <07f71b65-b900-62e2-6550-ae89708c9294@linux.intel.com> (raw)
In-Reply-To: <20220914023609.695296-1-rafaelmendsr@gmail.com>
On 14.9.2022 5.36, Rafael Mendonca wrote:
> If DbC is already in use, then the allocated memory for the xhci_dbc struct
> doesn't get freed before returning NULL, which leads to a memleak.
>
> Fixes: 534675942e90 ("xhci: dbc: refactor xhci_dbc_init()")
> Signed-off-by: Rafael Mendonca <rafaelmendsr@gmail.com>
Thanks, nice catch
Adding to queue
-Mathias
prev parent reply other threads:[~2022-09-14 12:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-14 2:36 [PATCH] xhci: dbc: Fix memory leak in xhci_alloc_dbc() Rafael Mendonca
2022-09-14 12:27 ` Mathias Nyman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=07f71b65-b900-62e2-6550-ae89708c9294@linux.intel.com \
--to=mathias.nyman@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.nyman@intel.com \
--cc=rafaelmendsr@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox